test: use countdown utility

[HarshithaKP]

Refs: #32082 (comment)

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[addaleax]

I’m not sure that this actually makes the code easier to understand…

[Trott]

I know @jasnell wrote it and likes it, so I'm always hesitant to express the opinion, but I dislike using the Countdown() abstraction in tests in most cases. Tests are the one place where readability is almost always more important than avoiding redundant code. As @addaleax notes, this doesn't make the test more readable.

[jasnell]

By adding the countdown you can eliminate the responses counter and the process.on('exit') check

[jasnell]

It's not always about making the code more understandable... this doesn't make it less understandable either. There is Do-thing-when-X-events-happen logic all over our tests and it has been done inconsistently and in some cases incorrectly. Countdown has allowed us to unify that logic. I'd be a strong -1 on going back to having every test implementing their own countdown logic.

[HarshithaKP]

1. I removed the need to use response variable, as per the suggestion
2. Is the difference in opinion on the usage of countdown latch in this particular test case, or its usage anywhere in general? Is there anything I can do to look at?

[addaleax]

Is the difference in opinion on the usage of countdown latch in this particular test case, or its usage anywhere in general?

@HarshithaKP A bit of both. Usually, the Countdown utility doesn’t add much value to a test. In this particular case, using it hides the fact that there is an explicit assertion about the number of responses.

My preference would be to not go ahead with this.

[HarshithaKP]

Closing based on the feedback.