[v13.x backport] stream: simplify Writable.write#32162
Closed
ronag wants to merge 1 commit intonodejs:v13.x-stagingfrom
Closed
[v13.x backport] stream: simplify Writable.write#32162ronag wants to merge 1 commit intonodejs:v13.x-stagingfrom
ronag wants to merge 1 commit intonodejs:v13.x-stagingfrom
Conversation
Member
Author
|
needs CI, Jenkins is however going down at the moment |
ronag
force-pushed
the
backport-31146-to-v13.x
branch
from
916e684 to
386ef63
Compare
ronag
force-pushed
the
backport-31146-to-v13.x
branch
from
386ef63 to
c935cd8
Compare
7 tasks
Backport-PR-URL: nodejs#32162
ronag
force-pushed
the
backport-31146-to-v13.x
branch
from
c935cd8 to
bf1bbe9
Compare
Member
Author
|
Note this actually backports two separate PR's. It was easier like this... |
Collaborator
Contributor
|
@ronag generally for backports we want to, as much as possible, keep the original commit meta data in place. In this case we have 3 commits that have now been merged into a single commit. Would it be a ton of extra work to retain that original structure? It makes it harder, at least for me, to review and compare the specific changes to see what the differences are... and almost requires full review now as it is a compeltely different patch then anything that we've landed |
Member
Author
|
@MylesBorins in this specific case it’s a bit harder. Since a commit both of these depend on seems to be missing. I can try again... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #31146, #31624
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes