Skip to content

meta: move maclover7 to Emeritus#31994

Merged
Trott merged 1 commit intonodejs:masterfrom
Trott:jm
Mar 1, 2020
Merged

meta: move maclover7 to Emeritus#31994
Trott merged 1 commit intonodejs:masterfrom
Trott:jm

Conversation

@Trott
Copy link
Member

@Trott Trott commented Feb 28, 2020

In email, maclover7 confirmed that are fine to move to emeritus status.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 28, 2020
@Trott
Copy link
Member Author

Trott commented Feb 28, 2020

@maclover7

MylesBorins
MylesBorins approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the hard work!

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2020
@Trott
meta: move maclover7 to Emeritus
ed16746 
In email, maclover7 confirmed that are fine to move to emeritus status.

PR-URL: nodejs#31994
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott merged commit ed16746 into nodejs:master Mar 1, 2020
@Trott
Copy link
Member Author

Trott commented Mar 1, 2020

Landed in ed16746

@Trott Trott deleted the jm branch March 1, 2020 05:07
@codebytere codebytere mentioned this pull request Mar 3, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 3, 2020
@Trott @codebytere
meta: move maclover7 to Emeritus
ded3890 
In email, maclover7 confirmed that are fine to move to emeritus status.

PR-URL: #31994
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
meta: move maclover7 to Emeritus
bcd0658 
In email, maclover7 confirmed that are fine to move to emeritus status.

PR-URL: #31994
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
meta: move maclover7 to Emeritus
b6b1c16 
In email, maclover7 confirmed that are fine to move to emeritus status.

PR-URL: #31994
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
meta: move maclover7 to Emeritus
a75aa93 
In email, maclover7 confirmed that are fine to move to emeritus status.

PR-URL: #31994
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

+2 more reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@mmarchini mmarchini mmarchini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Trott @MylesBorins @lpinca @cjihrig @mmarchini @gireeshpunathil @BridgeAR @nodejs-github-bot