[v13.x backport] stream: support passing generator functions into pipeline()#31975
Closed
ronag wants to merge 3 commits intonodejs:v13.x-stagingfrom
Closed
[v13.x backport] stream: support passing generator functions into pipeline()#31975ronag wants to merge 3 commits intonodejs:v13.x-stagingfrom
ronag wants to merge 3 commits intonodejs:v13.x-stagingfrom
Conversation
nodejs-github-bot
added
doc
Member
Author
|
Since this backport contains multiple commits I'm unsure where to add the |
Collaborator
ronag
added
stream
ronag
added
author ready
Backport-PR-URL: nodejs#31975 PR-URL: nodejs#31223 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
If the destination was an async function any error thrown from that function would be swallowed. Backport-PR-URL: nodejs#31975 PR-URL: nodejs#31835 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
There was an edge case where an incorrect assumption was made in regardos whether eos/finished means that the stream is actually destroyed or not. Backport-PR-URL: nodejs#31975 PR-URL: nodejs#31940 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
ronag
force-pushed
the
backport-pipeline-generator
branch
from
995dcc6 to
23011b9
Compare
Member
Author
|
Added Backport-PR-URL to each commit |
Member
|
@ronag each commit also needs the normal (update, nevermind - this looks like a bug in ncu landing behavior!) |
Member
|
@nodejs/releasers would someone else be willing to review this? with only 1 approval the required waiting period is 97 more hours and I'd like to finish preparing the release unless this can be left off it. It does, however, block clean landing of ~10 other streams backports. |
Trott
approved these changes
Feb 29, 2020
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
A little bit rubber-stampy of me but this looks good to me.
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 1, 2020
There was an edge case where an incorrect assumption was made in regardos whether eos/finished means that the stream is actually destroyed or not. Backport-PR-URL: #31975 PR-URL: #31940 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 8ad64b8...8a2b62e |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#31223
Also includes some required follow up fixes.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes