deps: V8: backport f7771e5b0cc4

[mmarchini]

This fixes a performance regression on V8 where frequent delete/reinsertions on a POJO object can lead to a bit overflow, causing subsequent property insertions to take exponentially more time.

We should try to backport this to v12, since the regression started there (yes, I'm volunteering to backport if it doesn't land cleanly).

---

Original commit message:

[runtime] Recompute enumeration indices of dictionaries upon bitfield overflow

Otherwise we'll get weird semantics when enumerating objects after many
deletes/reinserts.

Bug: chromium:1033771
Change-Id: If0a459169c3794a30d9632d09e80da3cfcd4302c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1993966
Commit-Queue: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Victor Gomes <victorgomes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65690}

Refs: v8/v8@f7771e5

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29357/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2891/

rerun linux: https://ci.nodejs.org/job/node-test-commit-linux/33112/
rerun linux, take 2: https://ci.nodejs.org/job/node-test-commit-linux/33114/

[MylesBorins]

LGTM

V8 CI is failing on two platforms but those are known failures. Re ran linux CI which was having an issue but this should be ready to land

[MylesBorins]

BTW this patch lands cleanly on both master and 13.x but will require a manual backport to 12.x

[mmarchini]

Landed in 3d894d0

[codebytere]

@MylesBorins i just tried and it seems to conflict on v13 🤔

node on git:v13.x-staging ❯ g cp 3d894d0511                                3:09PM
error: could not apply 3d894d0511... deps: V8: backport f7771e5b0cc4
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
Recorded preimage for 'common.gypi'

Not sure what the embedder string there should be, that's the conflict source.

[MylesBorins]

The embedder string conflict is expected. I'd refer to what the current number is on 13 and bump by 1

…

On Sat, Feb 29, 2020, 6:11 PM Shelley Vohr ***@***.***> wrote: @MylesBorins <https://github.com/MylesBorins> i just tried and it seems to conflict on v13 🤔 node on git:v13.x-staging ❯ g cp 3d894d0 <3d894d0> 3:09PM error: could not apply 3d894d0 <3d894d0>... deps: V8: backport f7771e5b0cc4 hint: after resolving the conflicts, mark the corrected paths hint: with 'git add <paths>' or 'git rm <paths>' hint: and commit the result with 'git commit' Recorded preimage for 'common.gypi' Not sure what the embedder string there should be, that's the conflict source. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#31957?email_source=notifications&email_token=AADZYV72PUADQWWDJX2D42LRFGKYJA5CNFSM4K3XRK42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMIN4Q#issuecomment-593004274>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADZYV5YQXM5UV7TFEMYHRLRFGKYJANCNFSM4K3XRK4Q> .