events: fix not emit removeListener

[fuxingZhang]

Fix not emit removeListener when eventName type is 'symbol'.

const EventEmitter = require('events');
const myEmitter = new EventEmitter();
const sym = Symbol('symbol');
const fn = () => { };
myEmitter.on(sym, fn);

myEmitter.on('removeListener', (...args) => {
  console.log('removeListener');
  console.log(args, args[0] === sym, args[1] === fn);
});

myEmitter.removeAllListeners()

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[addaleax]

Looks good!

Do you think you could add test for this?

[fuxingZhang]

Looks good!

Do you think you could add test for this?

I don't know yet, I'm not sure, but I can learn how to do it tomorrow or the day after tomorrow

[cjihrig]

LGTM, and based on your OP, you can probably use something like this as the test:

'use strict';
const common = require('../common');
const assert = require('assert');
const EventEmitter = require('events');
const myEmitter = new EventEmitter();
const sym = Symbol('symbol');
const fn = () => {};
myEmitter.on(sym, fn);

myEmitter.on('removeListener', common.mustCall((...args) => {
  assert.deepStrictEqual(args, [sym, fn]);
}));

myEmitter.removeAllListeners();

[BridgeAR]

LGTM with a test added

[fuxingZhang]

LGTM, and based on your OP, you can probably use something like this as the test:

'use strict';
const common = require('../common');
const assert = require('assert');
const EventEmitter = require('events');
const myEmitter = new EventEmitter();
const sym = Symbol('symbol');
const fn = () => {};
myEmitter.on(sym, fn);

myEmitter.on('removeListener', common.mustCall((...args) => {
  assert.deepStrictEqual(args, [sym, fn]);
}));

myEmitter.removeAllListeners();

Thank you, it was very helpful for me.
I have added the test code to an existing test file ‘test-event-emitter-remove-all-listeners.js’.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29230/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29613/

[ronag]

CI was 404, started another one

[Trott]

Landed in 1b3dbc9.

Thanks for the contribution! 🎉