module: disable conditional exports, self resolve warnings by guybedford · Pull Request #31845 · nodejs/node

guybedford · 2020-02-18T10:49:20Z

This removes the experimental warnings for using conditional exports and package self resolution, while keeping these features as experimental.

Currently the warnings are inhibiting usage of conditional exports (see #31819 and discussion at nodejs/modules#485), such that removing them will allow us to get more usage feedback.

At this stage it seems worthwhile to remove the warnings at this point to ensure we have adequate usage and feedback prior to unflagging on the 12.x backport.

We discussed this as a possibility at the last meeting, but it still needs approval from the modules group, so marking as an agenda item there and blocked for landing.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

guybedford · 2020-02-18T10:50:46Z

//cc @nodejs/modules-active-members

guybedford · 2020-02-18T11:33:13Z

I've gone ahead and also added the commit here to remove the experimental ES module warning.

lib/internal/modules/esm/loader.js

hybrist

LGTM - does it make sense to split this into two commits (modules vs. resolver feature warnings)?

guybedford · 2020-02-26T20:33:55Z

I've gone ahead and removed the experimental modules warnings removals from this PR, as per discussion in the meeting.

lib/internal/process/esm_loader.js

lib/internal/modules/esm/loader.js

nodejs-github-bot · 2020-02-26T20:36:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29392/

nodejs-github-bot · 2020-02-26T20:46:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/29393/

PR-URL: #31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

guybedford · 2020-02-26T21:23:30Z

Landed in 49ad161.

PR-URL: #31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

transitive-bullshit · 2020-04-20T08:02:06Z

Just tracked this down & wanted to say thanks for all your awesome work @guybedford 🙏😄

targos · 2020-04-20T19:37:05Z

This lands cleanly on v12.x-staging but the test fails, even if I add --experimental-modules to it. Please backport :)

guybedford · 2020-04-21T00:26:30Z

@targos I suspect this may be because #31757 should land first before this.

guybedford · 2020-04-21T00:28:32Z

Actually sorry that's already landed of course... ok let me look into this.

PR-URL: nodejs#31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

guybedford · 2020-04-21T00:46:31Z

@targos backport created at #32959. Note the changes are just the difference in requiring --experimental-modules, so as expected which is nice!

PR-URL: #31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Backport-PR-URL: #32959 Reviewed-By: Michaël Zasso <targos@protonmail.com>

Notable changes: Dependencies: * Updated OpenSSL to 1.1.1f. #32583 * Updated c-ares to 1.16.0. #32246 * Updated experimental uvwasi to 0.0.6. #32309 ESM (experimental): * Additional warnings are no longer printed for modules that use conditional exports or package name self resolution. #31845 PR-URL: #33009

Notable changes: Dependencies: * Updated OpenSSL to 1.1.1g. #32971 * Updated c-ares to 1.16.0. #32246 * Updated experimental uvwasi to 0.0.6. #32309 ESM (experimental): * Additional warnings are no longer printed for modules that use conditional exports or package name self resolution. #31845 PR-URL: #33009

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. labels Feb 18, 2020

guybedford added modules-agenda Issues and PRs to discuss during the meetings of the Modules team. pending labels Feb 18, 2020

guybedford mentioned this pull request Feb 18, 2020

ES modules warnings removal timelines nodejs/modules#485

Closed

ljharb reviewed Feb 18, 2020

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

guybedford force-pushed the remove-experimental-exports-warnings branch from 38eef00 to 5c339fd Compare February 18, 2020 19:17

module: disable conditional exports, self resolve warnings

0ce99ad

guybedford force-pushed the remove-experimental-exports-warnings branch from 5c339fd to 0ce99ad Compare February 18, 2020 22:15

hybrist approved these changes Feb 20, 2020

View reviewed changes

GeoffreyBooth approved these changes Feb 21, 2020

View reviewed changes

aduh95 mentioned this pull request Feb 22, 2020

Multiple Identical ExperimentalWarnings #31909

Closed

mhdawson mentioned this pull request Feb 24, 2020

Node.js Modules Team Meeting 2020-02-26 nodejs/modules#489

Closed

fixup: disable experimental-modules flag removal

98b1f93

ljharb reviewed Feb 26, 2020

View reviewed changes

lib/internal/process/esm_loader.js Show resolved Hide resolved

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

fixup: various

fd2c05b

guybedford force-pushed the remove-experimental-exports-warnings branch from 0760a08 to fd2c05b Compare February 26, 2020 20:41

guybedford removed modules-agenda Issues and PRs to discuss during the meetings of the Modules team. pending labels Feb 26, 2020

guybedford added a commit that referenced this pull request Feb 26, 2020

module: disable conditional exports, self resolve warnings

49ad161

PR-URL: #31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

guybedford closed this Feb 26, 2020

guybedford mentioned this pull request Feb 26, 2020

module: remove experimental modules warning #31974

Closed

4 tasks

codebytere pushed a commit that referenced this pull request Feb 27, 2020

module: disable conditional exports, self resolve warnings

b9f3bfe

PR-URL: #31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

codebytere mentioned this pull request Feb 29, 2020

v13.10.0 proposal #32027

Merged

targos pushed a commit that referenced this pull request Apr 18, 2020

module: disable conditional exports, self resolve warnings

85752cd

PR-URL: #31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

targos added the backport-requested-v12.x label Apr 20, 2020

guybedford added a commit to guybedford/node that referenced this pull request Apr 21, 2020

module: disable conditional exports, self resolve warnings

9ec497a

PR-URL: nodejs#31845 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>

guybedford mentioned this pull request Apr 21, 2020

[12.x] module: backport disable conditional exports, self resolve warnings #32959

Closed

4 tasks

targos mentioned this pull request Apr 22, 2020

v12.16.3 release proposal #33009

Merged

targos added backported-to-v12.x and removed backport-requested-v12.x labels May 8, 2020

cyungmann mentioned this pull request Sep 22, 2020

yargs is throwing a ExperimentalWarning yargs/yargs#1763

Closed

banga mentioned this pull request Jul 31, 2021

ExperimentalWarning message being displayed banga/git-split-diffs#20

Closed

Uh oh!

Conversation

guybedford commented Feb 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

guybedford commented Feb 18, 2020

Uh oh!

guybedford commented Feb 18, 2020

Uh oh!

Uh oh!

hybrist left a comment

Choose a reason for hiding this comment

Uh oh!

guybedford commented Feb 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 26, 2020

Uh oh!

nodejs-github-bot commented Feb 26, 2020

Uh oh!

guybedford commented Feb 26, 2020

Uh oh!

transitive-bullshit commented Apr 20, 2020

Uh oh!

targos commented Apr 20, 2020

Uh oh!

guybedford commented Apr 21, 2020

Uh oh!

guybedford commented Apr 21, 2020

Uh oh!

guybedford commented Apr 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

guybedford commented Feb 18, 2020 •

edited

Loading

guybedford commented Feb 26, 2020 •

edited

Loading