doc: add example for tls session resumption#3147
Closed
silverwind wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add example for tls session resumption#3147silverwind wants to merge 1 commit intonodejs:masterfrom
silverwind wants to merge 1 commit intonodejs:masterfrom
Conversation
silverwind
added
tls
Using TLS session resumption correctly is not obvious. This added example code should help new users understand how to use it correctly. Related issue: nodejs#3132
silverwind
force-pushed
the
doc-tls-session-ids
branch
from
30b35ab to
3ea5a60
Compare
Contributor
Author
|
Bump! Slightly updated wording and added a commit message. maybe @indutny can review? |
Member
|
LGTM |
Contributor
Author
|
Landed in 07a8419, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up in #3132. I was assuming this API was still synchronous while it was changed back in 75ea11f. Hopefully this example clears up on how to use TLS session resumption correctly.
cc: @bnoordhuis