src: suppress warning in src/node_env_var.cc#31136
Closed
HarshithaKP wants to merge 1 commit intonodejs:masterfrom
Closed
src: suppress warning in src/node_env_var.cc#31136HarshithaKP wants to merge 1 commit intonodejs:masterfrom
HarshithaKP wants to merge 1 commit intonodejs:masterfrom
Conversation
Initialise the superclass object in the copy constructor of mapKVStore
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Dec 30, 2019
Collaborator
Trott
approved these changes
Dec 30, 2019
lpinca
approved these changes
Dec 30, 2019
devnexen
approved these changes
Dec 30, 2019
cjihrig
approved these changes
Dec 31, 2019
BridgeAR
added
the
author ready
Collaborator
Collaborator
Member
|
Landed in 4614f64 |
Trott
pushed a commit
that referenced
this pull request
Jan 2, 2020
Initialise the superclass object in the copy constructor of mapKVStore PR-URL: #31136 Refs: #18983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Initialise the superclass object in the copy constructor of mapKVStore PR-URL: #31136 Refs: #18983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Initialise the superclass object in the copy constructor of mapKVStore PR-URL: #31136 Refs: #18983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Initialise the superclass object in the copy constructor of mapKVStore PR-URL: #31136 Refs: #18983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initialise the superclass object in the copy constructor of mapKVStore
Refs: #18983
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes