doc: implement minor improvements to BUILDING.md text#31070
Merged
Trott merged 0 commit intonodejs:masterfrom Dec 25, 2019
Merged
doc: implement minor improvements to BUILDING.md text#31070Trott merged 0 commit intonodejs:masterfrom
Trott merged 0 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
build
shisama
approved these changes
Dec 23, 2019
Trott
added
the
author ready
cjihrig
approved these changes
Dec 23, 2019
richardlau
approved these changes
Dec 23, 2019
Contributor
|
fast track? |
MylesBorins
added
the
fast-track
lpinca
approved these changes
Dec 23, 2019
gireeshpunathil
approved these changes
Dec 24, 2019
BridgeAR
approved these changes
Dec 24, 2019
Member
Author
|
Landed in 3987901 |
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
Fix comma splices. Remove unnecessary words. Minor text improvements. PR-URL: #31070 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
Fix comma splices. Remove unnecessary words. Minor text improvements. PR-URL: #31070 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Fix comma splices. Remove unnecessary words. Minor text improvements. PR-URL: #31070 Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix comma splices. Remove unnecessary words. Minor text improvements.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes