Skip to content

src: remove unused libraries#30827

Closed
juanarbol wants to merge 1 commit intonodejs:masterfrom
juanarbol:cc-unused-libs
Closed

src: remove unused libraries#30827
juanarbol wants to merge 1 commit intonodejs:masterfrom
juanarbol:cc-unused-libs

Conversation

@juanarbol
Copy link
Member

@juanarbol juanarbol commented Dec 6, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Dec 6, 2019
@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 7, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27460/

tniessen
tniessen previously approved these changes Dec 8, 2019
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27505/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27511/

@TimothyGu
Copy link
Member

TimothyGu commented Dec 9, 2019

Hmm, it appears that at least algorithm and memory are used, since the file explicitly references unique_ptr and find_if. Is there some context I'm missing?

@BridgeAR BridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 10, 2019
@juanarbol
Copy link
Member Author

juanarbol commented Dec 11, 2019

Sorry, I was based if it compiles, it works or something, so, I just saw a file where inclues specifies the used methods, I did the same here. Thanks @TimothyGu. I'll spend some time searching why this compiles.

@tniessen tniessen dismissed their stale review December 11, 2019 05:21

Does not apply anymore

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27651/

@Trott
Copy link
Member

Trott commented Dec 14, 2019

The C++ linter is flagging some issues with whitespace. make lint-cpp (or, on Windows, vcbuild lint-cpp) to see the results.

@Trott Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2019
richardlau
richardlau previously requested changes Dec 14, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message is no longer accurate.

@richardlau richardlau dismissed their stale review December 17, 2019 15:27

Commit message has been updated.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 17, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27769/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 18, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27774/

@BridgeAR
Copy link
Member

BridgeAR commented Dec 20, 2019

Landed in db9539b 🎉

BridgeAR pushed a commit that referenced this pull request Dec 20, 2019
@juanarbol @BridgeAR
src: list used functions on headers
db9539b 
PR-URL: #30827
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR closed this Dec 20, 2019
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@juanarbol @BridgeAR
src: list used functions on headers
6b65caf 
PR-URL: #30827
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@juanarbol @targos
src: list used functions on headers
3c63af2 
PR-URL: #30827
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@juanarbol @BethGriggs
src: list used functions on headers
f71b09f 
PR-URL: #30827
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
@juanarbol juanarbol deleted the cc-unused-libs branch January 19, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@JungMinu JungMinu JungMinu approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

@tniessen tniessen tniessen left review comments

@richardlau richardlau richardlau left review comments

+2 more reviewers

@antsmartian antsmartian antsmartian approved these changes

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.