fs: add synchronous retries to rimraf#30785
Closed
cjihrig wants to merge 3 commits intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
the
lib / src
Trott
approved these changes
Dec 4, 2019
This comment has been minimized.
This comment has been minimized.
Trott
added
the
author ready
2 tasks
bnoordhuis
reviewed
Dec 8, 2019
Trott
removed
the
author ready
Trott
added
the
author ready
This commit gives the synchronous version of rimraf the same linear retry logic as the asynchronous version. Prior to this commit, sync rimraf kept retrying the operation as soon as possible until maxRetries was reached.
This comment has been minimized.
This comment has been minimized.
rimraf should only retry if certain errors are encountered. Additionally, there is no point sleeping if an error occurs on the last try.
This comment has been minimized.
This comment has been minimized.
richardlau
approved these changes
Dec 8, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Contributor
Author
|
@Trott I don't think the CI is going to succeed until the out of space error in the |
Member
Don't confuse me with logic or data. You can't stop me from indiscriminately pressing "Resume Build" over and over. |
Contributor
Author
|
OK, maybe I was wrong. The latest CI run failed on ARM, but only because of the |
Collaborator
danbev
pushed a commit
that referenced
this pull request
Dec 9, 2019
This commit gives the synchronous version of rimraf the same linear retry logic as the asynchronous version. Prior to this commit, sync rimraf kept retrying the operation as soon as possible until maxRetries was reached. PR-URL: #30785 Fixes: #30580 Refs: #30569 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Contributor
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
This commit gives the synchronous version of rimraf the same linear retry logic as the asynchronous version. Prior to this commit, sync rimraf kept retrying the operation as soon as possible until maxRetries was reached. PR-URL: #30785 Fixes: #30580 Refs: #30569 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
This commit gives the synchronous version of rimraf the same linear retry logic as the asynchronous version. Prior to this commit, sync rimraf kept retrying the operation as soon as possible until maxRetries was reached. PR-URL: #30785 Fixes: #30580 Refs: #30569 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
This commit gives the synchronous version of rimraf the same linear retry logic as the asynchronous version. Prior to this commit, sync rimraf kept retrying the operation as soon as possible until maxRetries was reached. PR-URL: #30785 Fixes: #30580 Refs: #30569 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #30784 and #30783.
The third commit in this PR gives the synchronous version of rimraf the same linear retry logic as the asynchronous version. Prior to this commit, sync rimraf kept retrying the operation as soon as possible until
maxRetrieswas reached.Fixes: #30580
Refs: #30569
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes