test: use callback arguments in getconnections test#30775
Merged
Trott merged 0 commit intonodejs:masterfrom Dec 5, 2019
Merged
test: use callback arguments in getconnections test#30775Trott merged 0 commit intonodejs:masterfrom
Trott merged 0 commit intonodejs:masterfrom
Conversation
Collaborator
Collaborator
Collaborator
gengjiawen
approved these changes
Dec 4, 2019
Trott
added
the
author ready
lpinca
approved these changes
Dec 4, 2019
Member
Author
|
Landed in 7113d99 |
Trott
force-pushed
the
getconn-mustcall
branch
from
a42c2f4 to
7113d99
Compare
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
Use previously-unused callback arguments in test-child-process-fork-getconnections. PR-URL: #30775 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 13, 2020
Use previously-unused callback arguments in test-child-process-fork-getconnections. PR-URL: #30775 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Use previously-unused callback arguments in test-child-process-fork-getconnections. PR-URL: #30775 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use previously-unused callback arguments in
test-child-process-fork-getconnections.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes