doc: update status of Python 3 support#30722
Closed
mhdawson wants to merge 4 commits intonodejs:masterfrom
Closed
Conversation
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support.
nodejs-github-bot
added
build
Member
Author
|
@sam-github, @cclauss this reflect my understanding, can you validate? |
targos
reviewed
Nov 29, 2019
sam-github
reviewed
Nov 29, 2019
sam-github
approved these changes
Nov 29, 2019
Contributor
sam-github
left a comment
sam-github
left a comment
There was a problem hiding this comment.
A couple suggestions to simplify, but generally LGTM
addaleax
approved these changes
Nov 30, 2019
gengjiawen
approved these changes
Nov 30, 2019
jasnell
approved these changes
Dec 1, 2019
Co-Authored-By: Michaël Zasso <targos@protonmail.com>
joyeecheung
approved these changes
Dec 3, 2019
Member
Author
Contributor
|
Given that Python 2 end of life is in 29 days, I would recommend the following simplification:
|
Member
Author
|
CI good, just waiting for Travis to complete. |
Member
Author
|
Travis is good landing. |
mhdawson
added a commit
that referenced
this pull request
Dec 3, 2019
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. PR-URL: #30722 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Member
Author
|
Landed as 7bee77f |
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
Refs: nodejs/TSC#781 (comment) Based on the completion of the Python 3 strategic initiative, update statements around Python 3 support. PR-URL: #30722 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/TSC#781 (comment)
Based on the completion of the Python 3 strategic
initiative, update statements around Python 3 support.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes