Skip to content

doc: fix up N-API doc#30656

Closed
NickNaso wants to merge 2 commits intonodejs:masterfrom
NickNaso:fix-napi-doc
Closed

doc: fix up N-API doc#30656
NickNaso wants to merge 2 commits intonodejs:masterfrom
NickNaso:fix-napi-doc

Conversation

@NickNaso
Copy link
Member

@NickNaso NickNaso commented Nov 26, 2019

  • Fixed the signature for napi_status napi_get_uv_event_loop from:
NAPI_EXTERN napi_status napi_get_uv_event_loop(napi_env env,
                                               uv_loop_t** loop);

to:

NAPI_EXTERN napi_status napi_get_uv_event_loop(napi_env env,
                                               uv_loop_s** loop);
  • In section Simple Asynchronous Operations changed type napi_work to napi_async_work
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Nov 26, 2019
@NickNaso
Copy link
Member Author

NickNaso commented Nov 27, 2019

@mhdawson @gabrielf If you have time please review this PR.

mhdawson
mhdawson approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

legendecas
legendecas reviewed Nov 28, 2019
View reviewed changes
@mhdawson
Copy link
Member

mhdawson commented Nov 28, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4091/

danbev pushed a commit that referenced this pull request Dec 4, 2019
@NickNaso @danbev
doc: fix up N-API doc
9ed67f4 
PR-URL: #30656
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@danbev
Copy link
Contributor

danbev commented Dec 4, 2019

Landed in 9ed67f4.

@danbev danbev closed this Dec 4, 2019
targos pushed a commit that referenced this pull request Dec 9, 2019
@NickNaso @targos
doc: fix up N-API doc
543bf9d 
PR-URL: #30656
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@NickNaso @targos
doc: fix up N-API doc
1c452f0 
PR-URL: #30656
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@NickNaso @BethGriggs
doc: fix up N-API doc
005b601 
PR-URL: #30656
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@legendecas legendecas legendecas approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NickNaso @mhdawson @danbev @legendecas @nodejs-github-bot