build: use Node.js instead of Node in configure#30642
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
build: use Node.js instead of Node in configure#30642tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
richardlau
approved these changes
Nov 25, 2019
cjihrig
approved these changes
Nov 25, 2019
This comment has been minimized.
This comment has been minimized.
devsnek
approved these changes
Nov 25, 2019
gengjiawen
approved these changes
Nov 26, 2019
trivikr
approved these changes
Nov 26, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
devnexen
approved these changes
Nov 26, 2019
This comment has been minimized.
This comment has been minimized.
lpinca
approved these changes
Nov 27, 2019
This comment has been minimized.
This comment has been minimized.
addaleax
added
the
author ready
This comment has been minimized.
This comment has been minimized.
Collaborator
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30642 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 08a40e2 |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
PR-URL: #30642 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
tniessen
removed
the
author ready
This was referenced Aug 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that this is required as per our branding guideline, but I might be mistaken.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes