Skip to content

refactor test#30568

Closed
JenyMzo wants to merge 2 commits intonodejs:masterfrom
JenyMzo:test-createHook
Closed

refactor test#30568
JenyMzo wants to merge 2 commits intonodejs:masterfrom
JenyMzo:test-createHook

Conversation

@JenyMzo
Copy link
Contributor

@JenyMzo JenyMzo commented Nov 20, 2019

Switch the argument order for the assertion to be in the correct order (actual, expected).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 20, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 20, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 20, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26798/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26803/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 21, 2019 

06:36:04 ok 2756 sequential/test-inspector-module
06:36:04   ---
06:36:04   duration_ms: 0.219
06:36:04   ...
06:39:52 FATAL: command execution failed
06:39:52 java.nio.channels.ClosedChannelException
06:39:52 	at org.jenkinsci.remoting.protocol.impl.ChannelApplicationLayer.onReadClosed(ChannelApplicationLayer.java:209)
06:39:52 	at org.jenkinsci.remoting.protocol.ApplicationLayer.onRecvClosed(ApplicationLayer.java:222)
06:39:52 	at org.jenkinsci.remoting.protocol.ProtocolStack$Ptr.onRecvClosed(ProtocolStack.java:816)
06:39:52 	at org.jenkinsci.remoting.protocol.FilterLayer.onRecvClosed(FilterLayer.java:287)
06:39:52 	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.onRecvClosed(SSLEngineFilterLayer.java:181)
06:39:52 	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.switchToNoSecure(SSLEngineFilterLayer.java:283)
06:39:52 	at org.jenkinsci.remoting.protocol.impl.SSLEngineFilterLayer.processWrite(SSLEngineFilterLayer.java:503)

looks like the some infra issues caused the CI to fail. Let us see if a resume build fixes that.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 21, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/26804/

@JenyMzo JenyMzo changed the title refactor test test: refactor createHook rest Nov 21, 2019
@JenyMzo JenyMzo changed the title test: refactor createHook rest test: refactor createHook test Nov 21, 2019
@JenyMzo JenyMzo changed the title test: refactor createHook test refactor test Nov 21, 2019
jessecogollo
jessecogollo approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@jessecogollo jessecogollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you rock !!! 👏 🚀

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 29, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27166/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 30, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/27189/

@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 30, 2019

the only failure in linix-containerized parallel/test-readline-async-iterators-destroy is known as in #30660

gireeshpunathil pushed a commit that referenced this pull request Nov 30, 2019
@JenyMzo @gireeshpunathil
test:refactor createHook test
246557e 
PR-URL: #30568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gireeshpunathil
Copy link
Member

gireeshpunathil commented Nov 30, 2019

landed in 246557e.

thanks for the contribution!

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@JenyMzo @addaleax
test:refactor createHook test
ba0115f 
PR-URL: #30568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
targos pushed a commit that referenced this pull request Dec 5, 2019
@JenyMzo @targos
test:refactor createHook test
c4c5912 
PR-URL: #30568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@JenyMzo @MylesBorins
test:refactor createHook test
9f49b97 
PR-URL: #30568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+2 more reviewers

@jessecogollo jessecogollo jessecogollo approved these changes

@devnexen devnexen devnexen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@JenyMzo @nodejs-github-bot @gireeshpunathil @addaleax @jessecogollo @cjihrig @devnexen @Trott