dns: add missing exports.BADNAME by silverwind · Pull Request #3051 · nodejs/node

silverwind · 2015-09-24T14:46:43Z

Fixes #3050. Looks to be an mistake in ecfe32e.

evanlucas · 2015-09-24T14:51:45Z

Yea, I would say this is semver-major for sure.

silverwind · 2015-09-24T14:51:54Z

Reconsidered the semver thing, I'll make it major just in case.

evanlucas · 2015-09-24T14:55:15Z

https://github.com/search?l=javascript&q=dns.ADNAME&type=Code&utf8=%E2%9C%93 shows some uses of it in packages. OTOH, it is documented as being dns.BADNAME

ChALkeR · 2015-09-24T14:57:46Z

For 5.x, this should remove EADNAME and add EBADNAME (semver-major).
For 4.x, this should just add EBADNAME, without removing EADNAME (semver-minor or even a patch, because it was documented).

silverwind · 2015-09-24T14:59:19Z

That looks like one public use case. I think it's fine if we target this to 5.0.0, it took people 3,5 years to notice that mistake, so can't be this urgent :)

ChALkeR · 2015-09-24T15:08:27Z

This list is partial (≈30%) and quite old (3⅔ months):

EADNAME:

c/cares-1.0.1.tgz/lib/cares.js:381:exports.ADNAME = 'EADNAME';

EBADNAME:

g/google-closure-compiler-20150505.0.0.tgz/contrib/nodejs/dns.js:146:dns.BADNAME = 'EBADNAME';
t/tftp-0.1.1.tgz/lib/protocol/errors.js:50:define ("EBADNAME", "Invalid filename");
t/tftp-0.1.1.tgz/lib/protocol/packets/read-request.js:14:               throw errors.EBADNAME;

Full and updated data file is still building (25% done).

Looks that ADNAME isn't really used at least by module authors.

Updated (searched over those 25%) :

aqua-1.0.0.tgz/externs/nodejs/dns.js:144:dns.BADNAME = 'EBADNAME';
biojs-vis-blast-0.1.5.tgz/node/lib/dns.js:323:exports.ADNAME = 'EADNAME';
cares-1.0.1.tgz/lib/cares.js:381:exports.ADNAME = 'EADNAME';
chromify-0.0.2.tgz/builtins/dns.js:211:exports.BADNAME = 'EBADNAME';
closurecompiler-externs-1.0.4.tgz/dns.js:144:dns.BADNAME = 'EBADNAME';
commonjs-everywhere-0.9.7.tgz/node/lib/dns.js:203:exports.ADNAME = 'EADNAME';
dnsjs-0.1.1.tgz/lib/index.js:37:    this.BADNAME = consts.BADNAME;
dnsjs-0.1.1.tgz/lib/index.js:286:    this.BADNAME = consts.BADNAME;
dnsjs-0.1.1.tgz/mocha/tests.js:39:    this.BADNAME = consts.BADNAME;
dnsjs-0.1.1.tgz/mocha/tests.js:288:    this.BADNAME = consts.BADNAME;
dnsjs-0.1.1.tgz/mocha/tests.js:14071:  BADNAME: 20,
dnsjs-0.1.1.tgz/mocha/tests.js:14077:exports.BADNAME = 'EBADNAME';
e2e-0.0.6.tgz/end-to-end/lib/closure-compiler/contrib/nodejs/dns.js:146:dns.BADNAME = 'EBADNAME';
flush-all-0.1.1.tgz/node-v0.13/lib/dns.js:323:exports.ADNAME = 'EADNAME';

Edit: updated a bit.

silverwind · 2015-09-24T15:14:50Z

Thanks for that analyses @ChALkeR, much appreciated.

thefourtheye · 2015-09-25T10:55:27Z

For 5.x, this should remove EADNAME and add EBADNAME (semver-major).
For 4.x, this should just add EBADNAME, without removing EADNAME (semver-minor or even a patch, because it was documented).

I agree with @ChALkeR. Probably, we can introduce the documentation entry for ADNAME in 4.x and indicate that this will be fixed in 5.x?

silverwind · 2015-09-25T15:02:51Z

I don't really see a benefit in documenting the missspelled property. I think I'll go with a patch commit for the addition of the value and a semver-major for the removal of the wrong value.

ChALkeR · 2015-09-25T15:32:41Z

@silverwind

I don't really see a benefit in documenting the missspelled property. I think I'll go with a patch commit for the addition of the value and a semver-major for the removal of the wrong value.

+1

ChALkeR · 2015-09-26T13:03:44Z

And the updated (2015-09-21) and more complete (all the current version of packages, except for the minified code) list is here.

Everything that includes ADNAME (with BADNAME, EADNAME, and EBADNAME) :

aqua-1.0.0.tgz/externs/nodejs/dns.js:144:dns.BADNAME = 'EBADNAME';
biojs-vis-blast-0.1.5.tgz/node/lib/dns.js:323:exports.ADNAME = 'EADNAME';
cares-1.0.1.tgz/lib/cares.js:381:exports.ADNAME = 'EADNAME';
chromify-0.0.2.tgz/builtins/dns.js:211:exports.BADNAME = 'EBADNAME';
closurecompiler-externs-1.0.4.tgz/dns.js:144:dns.BADNAME = 'EBADNAME';
commonjs-everywhere-0.9.7.tgz/node/lib/dns.js:203:exports.ADNAME = 'EADNAME';
dnsjs-0.1.1.tgz/lib/index.js:37:    this.BADNAME = consts.BADNAME;
dnsjs-0.1.1.tgz/lib/index.js:286:    this.BADNAME = consts.BADNAME;
dnsjs-0.1.1.tgz/mocha/tests.js:39:    this.BADNAME = consts.BADNAME;
dnsjs-0.1.1.tgz/mocha/tests.js:288:    this.BADNAME = consts.BADNAME;
dnsjs-0.1.1.tgz/mocha/tests.js:14071:  BADNAME: 20,
dnsjs-0.1.1.tgz/mocha/tests.js:14077:exports.BADNAME = 'EBADNAME';
e2e-0.0.6.tgz/end-to-end/lib/closure-compiler/contrib/nodejs/dns.js:146:dns.BADNAME = 'EBADNAME';
flush-all-0.1.1.tgz/node-v0.13/lib/dns.js:323:exports.ADNAME = 'EADNAME';
google-closure-compiler-20150901.0.0.tgz/contrib/nodejs/dns.js:146:dns.BADNAME = 'EBADNAME';
Haraka-2.6.1.tgz/outbound.js:807:    // BADNAME
jsg-0.0.3.tgz/testdata/node_core_modules/dns.js:258:exports.ADNAME = 'EADNAME';
native-dns-0.7.0.tgz/dns.js:42:exports.BADNAME = consts.BADNAME;
native-dns-packet-0.1.1.tgz/consts.js:151:  BADNAME: 20,
native-dns-packet-0.1.1.tgz/consts.js:157:exports.BADNAME = 'EBADNAME';
nice-http-0.1.0-alfa.tgz/src/dns.js:256:exports.ADNAME = 'EADNAME';
nmcns-0.1.3.tgz/mocha/tests.js:13489:    this.BADNAME = consts.BADNAME;
nmcns-0.1.3.tgz/mocha/tests.js:13738:    this.BADNAME = consts.BADNAME;
nmcns-0.1.3.tgz/mocha/tests.js:31711:  BADNAME: 20,
nmcns-0.1.3.tgz/mocha/tests.js:31717:exports.BADNAME = 'EBADNAME';
node-core-lib-0.11.11.tgz/dns.js:258:exports.ADNAME = 'EADNAME';
nodedbi-1.0.7.tgz/index.js:9:  DBI_ERROR_BADNAME,
nodedbi-1.0.7.tgz/index.js:23:nodedbi['DBI_ERROR_BADNAME'] = -5;
nodejs-externs-0.10.1.tgz/externs/dns.js:144:dns.BADNAME = 'EBADNAME';
node-natives-0.10.25.tgz/dns.js:203:exports.ADNAME = 'EADNAME';
pezhu-0.0.0.tgz/Downloads/node-v0.9.11/lib/dns.js:202:exports.ADNAME = 'EADNAME';
pn-0.0.1.tgz/dns.js:7:  ADNAME: { enumerable: true, value: dns.ADNAME },
portable-js-0.0.3.tgz/misc/io/dns.js:338:exports.ADNAME = 'EADNAME';
portable-js-0.0.3.tgz/misc/node/dns.js:325:exports.ADNAME = 'EADNAME';
sawrocket-xmpp-0.3.0.tgz/sawrocket-xmpp.browser.js:14164:exports.BADNAME = consts.BADNAME;
sawrocket-xmpp-0.3.0.tgz/sawrocket-xmpp.browser.js:17115:  BADNAME: 20,
sawrocket-xmpp-0.3.0.tgz/sawrocket-xmpp.browser.js:17121:exports.BADNAME = 'EBADNAME';
smb2-0.2.6.tgz/lib/tools/ms_erref.js:17712:    "code":"ERROR_SXS_XML_E_BADNAMECHAR"
srb-0.1.14.tgz/lib/tasks/dns.js:14:dns.BADNAME: Misformatted domain name.
tftp-0.1.2.tgz/lib/protocol/errors.js:50:define ("EBADNAME", "Invalid filename");
tftp-0.1.2.tgz/lib/protocol/packets/read-request.js:14:                throw errors.EBADNAME;

silverwind · 2015-09-26T13:12:51Z

Changed this PR to just add the missing EBADNAME. The part which removes EADNAME is at #3076. PTAL.

targos · 2015-09-26T13:13:43Z

LGTM

silverwind · 2015-09-26T13:15:12Z

Fixed the commit title.

ChALkeR · 2015-09-26T13:48:51Z

LGTM.

This is not a semver-minor, but a patch, because it's actually a bugfix (dns.BADNAME is documented but actually missing atm).

ChALkeR · 2015-09-26T13:50:14Z

@silverwind Could you add that to the commit message details, btw (the fact that it was documented)?

silverwind · 2015-09-26T14:02:01Z

Yeah, will add a description and links to the commit when I land this tomorrow.

evanlucas · 2015-09-26T20:23:34Z

LGTM

Adds the documented but missing DNS error exports.BADNAME. This export has been there before but got lost in a 2012 commit that added more error codes. #3076 will remove the wrong error code exports.ADNAME. PR-URL: #3051 Fixes: #3050 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

This error code export was mistakingly introduced in a 2012 commit which added more error codes. The correct export.BADNAME was added in nodejs#3051. Semver: Major PR-URL: nodejs#3051 Fixes: nodejs#3050

This error code export was mistakingly introduced in a 2012 commit which added more error codes. The correct export.BADNAME was added in #3051. Semver: Major PR-URL: #3051 Fixes: #3050 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

Adds the documented but missing DNS error exports.BADNAME. This export has been there before but got lost in a 2012 commit that added more error codes. #3076 will remove the wrong error code exports.ADNAME. PR-URL: #3051 Fixes: #3050 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

This error code export was mistakingly introduced in a 2012 commit which added more error codes. The correct export.BADNAME was added in #3051. Semver: Major PR-URL: #3051 Fixes: #3050 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

silverwind added the dns Issues and PRs related to the dns subsystem. label Sep 24, 2015

silverwind mentioned this pull request Sep 24, 2015

Shouldn't DNS error code 'EADNAME' be 'EBADNAME'? #3050

Closed

silverwind added the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 24, 2015

silverwind force-pushed the EBADNAME branch from e5d4d01 to 941a554 Compare September 26, 2015 13:08

silverwind changed the title ~~dns: add missing dns.BADNAME in place of dns.ADNAME~~ dns: add missing exports.EBADNAME Sep 26, 2015

silverwind removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Sep 26, 2015

silverwind mentioned this pull request Sep 26, 2015

dns: remove exports.ADNAME #3076

Closed

dns: add missing exports.BADNAME

804e0c2

silverwind force-pushed the EBADNAME branch from 941a554 to 804e0c2 Compare September 26, 2015 13:14

silverwind changed the title ~~dns: add missing exports.EBADNAME~~ dns: add missing exports.BADNAME Sep 26, 2015

ChALkeR mentioned this pull request Sep 26, 2015

dns.ADNAME is a mistype in Node.js core dns module and will be removed cscott/node-pn#1

Closed

silverwind closed this Sep 27, 2015

This was referenced Sep 30, 2015

Release proposal: v4.1.2 #3127

Closed

Release proposal: v4.1.2 #3128

Closed

This was referenced Oct 27, 2015

Release proposal: v5.0.0 #3466

Merged

Preparing v4.2.2 LTS Maintenance nodejs/Release#50

Closed

Krinkle mentioned this pull request Nov 2, 2015

Prefix commit subjects with semver level jquery/contribute.jquery.org#130

Closed

rvagg mentioned this pull request Dec 17, 2015

Release 4.2.4 Planning #4321

Closed

jasnell added the lts-watch-v4.x label Dec 17, 2015

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Dec 29, 2015

MylesBorins mentioned this pull request Jan 14, 2016

Audit commits not found on v4.x-staging #4698

Closed

MylesBorins mentioned this pull request Jan 19, 2016

V4.2.5 proposal #4768

Merged

Uh oh!

Conversation

silverwind commented Sep 24, 2015

Uh oh!

evanlucas commented Sep 24, 2015

Uh oh!

silverwind commented Sep 24, 2015

Uh oh!

evanlucas commented Sep 24, 2015

Uh oh!

ChALkeR commented Sep 24, 2015

Uh oh!

silverwind commented Sep 24, 2015

Uh oh!

ChALkeR commented Sep 24, 2015

Uh oh!

silverwind commented Sep 24, 2015

Uh oh!

thefourtheye commented Sep 25, 2015

Uh oh!

silverwind commented Sep 25, 2015

Uh oh!

ChALkeR commented Sep 25, 2015

Uh oh!

ChALkeR commented Sep 26, 2015

Uh oh!

silverwind commented Sep 26, 2015

Uh oh!

targos commented Sep 26, 2015

Uh oh!

silverwind commented Sep 26, 2015

Uh oh!

ChALkeR commented Sep 26, 2015

Uh oh!

ChALkeR commented Sep 26, 2015

Uh oh!

silverwind commented Sep 26, 2015

Uh oh!

evanlucas commented Sep 26, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants