benchmark: use let instead of var in assert

[dnlup]

Use let instead of var in benchmark/assert/deepequal-buffer.js.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[trivikr]

LGTM, just some nits

[SimonSchick]

Going slightly out of scope.
@trivikr if I was to submit a PR that changed all for(regular/in/of) loops to let/const respectively, would this be accepted?

[trivikr]

if I was to submit a PR that changed all for(regular/in/of) loops to let/const respectively, would this be accepted?

@SimonSchick Short answer is most likely "No"

This is one of the Code and Learn tasks from workshop at NodeConfEU:

• Label for other PRs code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.
• Conference schedule https://www.nodeconf.eu/schedule/
  • Workshop was conducted at 1400 hours UTC+00:00 on Monday, November 11, 2019

There are many other PRs which are doing var to let/const replacements in other files.
If you are interested, please wait for some time (say a month) for all those PRs to be merged, and then create your PR. Other options:

• go through all open code-and-learn PRs to find out which files are not touched
• ping NodeConfEU code-and-learn organizers @jasnell / @addaleax / @BridgeAR to find files which are yet to be updated.

I don't recommend doing it for all files at once it'l be difficult to review. For example, we still use var at some places for:

• performance reasons (lib: adding optemisation notes, leaving var in place in js_stream_socket.js #30415)
• upstream code uses var (test: replace var with let in test/parallel/test-whatwg-url-toascii.js #30378 (comment))

I think you can replace vs to let/const on module basis (one PR for http, one for fs etc) so that only the particular module team can review it.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/26547/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/26644/

[gireeshpunathil]

landed in d1ce04c , thanks for the contribution!