doc: esm: improve dual package hazard docs#30345
Closed
GeoffreyBooth wants to merge 9 commits intonodejs:masterfrom
Closed
doc: esm: improve dual package hazard docs#30345GeoffreyBooth wants to merge 9 commits intonodejs:masterfrom
GeoffreyBooth wants to merge 9 commits intonodejs:masterfrom
Conversation
guybedford
reviewed
Nov 10, 2019
guybedford
reviewed
Nov 10, 2019
guybedford
reviewed
Nov 11, 2019
guybedford
reviewed
Nov 11, 2019
guybedford
reviewed
Nov 11, 2019
guybedford
reviewed
Nov 11, 2019
guybedford
reviewed
Nov 11, 2019
GeoffreyBooth
force-pushed
the
dual-package-docs
branch
from
f0ed938 to
ea9f231
Compare
Contributor
|
What I'm looking for specifically is a note like -
|
Contributor
|
The problem specifically is that the break is not visible in testing, and will only become obvious much further down the line. |
GeoffreyBooth
force-pushed
the
dual-package-docs
branch
3 times, most recently
from
0ba8715 to
68ab812
Compare
guybedford
reviewed
Nov 12, 2019
guybedford
reviewed
Nov 12, 2019
GeoffreyBooth
force-pushed
the
dual-package-docs
branch
from
68ab812 to
1f7b577
Compare
guybedford
approved these changes
Nov 12, 2019
hybrist
approved these changes
Nov 12, 2019
robpalme
reviewed
Nov 13, 2019
Contributor
robpalme
left a comment
robpalme
left a comment
There was a problem hiding this comment.
Minor wording suggestions.
GeoffreyBooth
force-pushed
the
dual-package-docs
branch
from
db5a875 to
6c7e610
Compare
guybedford
reviewed
Nov 14, 2019
guybedford
reviewed
Nov 14, 2019
guybedford
reviewed
Nov 14, 2019
guybedford
reviewed
Nov 14, 2019
GeoffreyBooth
force-pushed
the
dual-package-docs
branch
from
6c7e610 to
4b75b64
Compare
guybedford
approved these changes
Nov 14, 2019
guybedford
added
the
author ready
Collaborator
Collaborator
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30345 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Contributor
|
landed in d9efc7d |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 17, 2019
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30345 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 12, 2020
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30345 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Co-Authored-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> PR-URL: #30345 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the ES modules docs regarding hazards related to dual packages per the findings in nodejs/modules#409. Basically, the hazard that we previously thought was isolated to divergent specifiers (e.g.
'pkg'resolving toindex.cjsfor CommonJS andindex.mjsfor ESM) happens for all dual packages even if the two entry points are at different specifiers (e.g.'pkg'and'pkg/module'). Therefore the section on writing dual packages applies not just to conditional exports but to the ES modules implementation generally.Follow up to #30051.
cc @guybedford @MylesBorins @nodejs/modules-active-members
Checklist