test: refactor test-accessor-properties#29943
Closed
himself65 wants to merge 2 commits intonodejs:masterfrom
Closed
test: refactor test-accessor-properties#29943himself65 wants to merge 2 commits intonodejs:masterfrom
himself65 wants to merge 2 commits intonodejs:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Fishrock123
previously requested changes
Oct 12, 2019
Contributor
Fishrock123
left a comment
Fishrock123
left a comment
There was a problem hiding this comment.
I think we should change the TTY ones but not the UDP ones.
Trott
previously requested changes
Oct 12, 2019
Member
There was a problem hiding this comment.
The more I think about it: I'm actually opposed to all of it. This sort of thing makes sense in lib but not in test. Repetition is fine, even desirable, in the tests. The current code makes it easy to understand what is being tested. The change here makes it less readable IMO. (I'll relent if there is a lot of support for this, though.)
@nodejs/testing
Trott
reviewed
Oct 13, 2019
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Trott
dismissed
their stale review
This is no longer adding a forEach so I'm going to unblock.
addaleax
approved these changes
Nov 30, 2019
addaleax
added
the
author ready
Collaborator
BridgeAR
approved these changes
Dec 9, 2019
BridgeAR
pushed a commit
that referenced
this pull request
Dec 9, 2019
PR-URL: #29943 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in 2f8c858 🎉 |
targos
pushed a commit
that referenced
this pull request
Dec 10, 2019
PR-URL: #29943 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #29943 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #29943 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes