net: treat ENOTCONN at shutdown as success#29912
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
net: treat ENOTCONN at shutdown as success#29912addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
While it is not entirely clear why this condition is being triggered, it does resolve a reported bug. Fixes: nodejs#26315
Collaborator
Collaborator
Member
Author
|
@nodejs/collaborators This could use a review or two. |
jasnell
approved these changes
Oct 11, 2019
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM, but is there anything reasonable that can be included in the docs about this?
Member
Author
|
@jasnell I wouldn’t know how or what to document. This kind of just makes behaviour be what it should be in the first place. |
Member
|
Yeah, that's kind of what I expected. |
lpinca
approved these changes
Oct 11, 2019
addaleax
added
author ready
Member
Author
|
Landed in 1447a79 |
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Oct 14, 2019
While it is not entirely clear why this condition is being triggered, it does resolve a reported bug. Fixes: nodejs#26315 PR-URL: nodejs#29912 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Oct 14, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While it is not entirely clear why this condition is being
triggered, it does resolve a reported bug.
Fixes: #26315
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes