doc: Remove extra "using v8::HandleScope;" statements from addons.markdown#2983
Closed
brody4hire wants to merge 1 commit intonodejs:masterfrom
Closed
doc: Remove extra "using v8::HandleScope;" statements from addons.markdown#2983brody4hire wants to merge 1 commit intonodejs:masterfrom
brody4hire wants to merge 1 commit intonodejs:masterfrom
Conversation
v8::HandleScope does not seem to be required for addon functions.
bnoordhuis
pushed a commit
that referenced
this pull request
Sep 21, 2015
v8::HandleScope does not seem to be required for addon functions. PR-URL: #2983 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Member
|
LGTM and thanks, guess I missed that when I rewrote the docs. Landed in 451acc7. |
Author
|
👍 |
rvagg
pushed a commit
that referenced
this pull request
Sep 22, 2015
v8::HandleScope does not seem to be required for addon functions. PR-URL: #2983 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Contributor
|
landed in lts-v4.x-staging as 9c59d2f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8::HandleScope does not seem to be required for addon functions. Exception seems to be in AtExit hooks section.