configure: detect mipsel host#2971
Closed
kapouer wants to merge 1 commit intonodejs:masterfrom
kapouer:patch-3
Closed
configure: detect mipsel host#2971kapouer wants to merge 1 commit intonodejs:masterfrom kapouer:patch-3
kapouer wants to merge 1 commit intonodejs:masterfrom
kapouer:patch-3
Conversation
Detect mipsel before mips because mipsel has __mips__ flag as well.
Member
|
What hardware are you testing on? |
Contributor
Author
|
On that testing machine i discovered detected host != --dest-cpu (mips != mipsel): |
Contributor
Author
Member
|
I don't have mips hardware to reproduce this, but LGTM. I can merge this in a day or so unless anyone objects. |
Contributor
|
cc @nodejs/build |
bnoordhuis
pushed a commit
that referenced
this pull request
Sep 21, 2015
Detect mipsel before mips because mipsel has __mips__ flag as well. PR-URL: #2971 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Member
|
LGTM2. Landed in 5819d7a, thanks. |
rvagg
pushed a commit
that referenced
this pull request
Sep 22, 2015
Detect mipsel before mips because mipsel has __mips__ flag as well. PR-URL: #2971 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Contributor
|
landed in lts-v4.x-staging as f010cb5 |
This was referenced Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect mipsel before mips because mipsel has
__mips__flag as well.