doc: improve UV_THREADPOOL_SIZE description#29033
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
doc: improve UV_THREADPOOL_SIZE description#29033tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
cli
cjihrig
approved these changes
Aug 7, 2019
antsmartian
approved these changes
Aug 7, 2019
antsmartian
added
the
author ready
bnoordhuis
approved these changes
Aug 7, 2019
BethGriggs
approved these changes
Aug 7, 2019
jasnell
approved these changes
Aug 7, 2019
Trott
approved these changes
Aug 7, 2019
trivikr
approved these changes
Aug 8, 2019
Member
lpinca
approved these changes
Aug 9, 2019
Member
Author
|
Landed in 885c644, thanks for reviewing! |
tniessen
added a commit
that referenced
this pull request
Aug 9, 2019
PR-URL: #29033 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
PR-URL: #29033 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Aug 20, 2019
tniessen
removed
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
UV_THREADPOOL_SIZEdocumentation claims that only threecryptoAPIs use the thread pool, which is not true anymore. This commit lists all relevant APIs and rephrases it such that future API additions are included in the documentation.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes