doc: mention N-API as recommended approach#28922
Closed
mhdawson wants to merge 6 commits intonodejs:masterfrom
Closed
doc: mention N-API as recommended approach#28922mhdawson wants to merge 6 commits intonodejs:masterfrom
mhdawson wants to merge 6 commits intonodejs:masterfrom
Conversation
We've had a few comments that from the doc it might not be clear that N-API is the recommended approach for Addons. As a start, mention N-API early in the non N-API section as the recommended approach unless lower level access is required.
nodejs-github-bot
added
addons
richardlau
approved these changes
Aug 1, 2019
Member
Author
|
@cjihrig update to say 3 and include nan |
lpinca
approved these changes
Aug 3, 2019
Trott
reviewed
Aug 4, 2019
Trott
reviewed
Aug 4, 2019
Trott
reviewed
Aug 4, 2019
Trott
reviewed
Aug 4, 2019
Trott
approved these changes
Aug 4, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Good as-is, although I have a preference for the suggestions I've left which mostly make things more succinct..
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
mhdawson
added
the
author ready
Member
trivikr
approved these changes
Aug 16, 2019
jasnell
approved these changes
Aug 16, 2019
Member
Author
|
Lite CI was good, landing. |
Member
Author
|
Landed as 18405e6 |
mhdawson
added a commit
that referenced
this pull request
Aug 16, 2019
We've had a few comments that from the doc it might not be clear that N-API is the recommended approach for Addons. As a start, mention N-API early in the non N-API section as the recommended approach unless lower level access is required. PR-URL: #28922 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
We've had a few comments that from the doc it might not be clear that N-API is the recommended approach for Addons. As a start, mention N-API early in the non N-API section as the recommended approach unless lower level access is required. PR-URL: #28922 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Aug 20, 2019
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had a few comments that from the doc it might not
be clear that N-API is the recommended approach for Addons.
As a start, mention N-API early in the non N-API section
as the recommended approach unless lower level access
is required.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes