n-api: refactoring napi_create_function testing#28894
Closed
octaviansoldea wants to merge 1 commit intonodejs:masterfrom
Closed
n-api: refactoring napi_create_function testing#28894octaviansoldea wants to merge 1 commit intonodejs:masterfrom
octaviansoldea wants to merge 1 commit intonodejs:masterfrom
Conversation
PR-URL: nodejs#26998 This is a refactoring of nodejs#26998 following nodejs#28505. The functions `add_last_status()` and `add_returned_status()` are now reused, see also nodejs#28848. PR-URL: nodejs#26998 PR-URL: nodejs#28505 PR-URL: nodejs#28848
gabrielschulhof
approved these changes
Jul 30, 2019
Collaborator
Trott
approved these changes
Aug 1, 2019
Member
|
Landed in 1ee47d5 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 1, 2019
This is a refactoring of nodejs#26998 following nodejs#28505. The functions `add_last_status()` and `add_returned_status()` are now reused, see also nodejs#28848. PR-URL: nodejs#28894 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
This is a refactoring of #26998 following #28505. The functions `add_last_status()` and `add_returned_status()` are now reused, see also #28848. PR-URL: #28894 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #26998
This is a refactoring of #26998
following #28505.
The functions
add_last_status()andadd_returned_status()are nowreused, see also #28848.
PR-URL: #26998
PR-URL: #28505
PR-URL: #28848
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes