test, util: refactor isObject in test-util#28878
Closed
RamirezAlex wants to merge 1 commit intonodejs:masterfrom
Closed
test, util: refactor isObject in test-util#28878RamirezAlex wants to merge 1 commit intonodejs:masterfrom
RamirezAlex wants to merge 1 commit intonodejs:masterfrom
Conversation
refactor the test for isObject function including falsy values, the use of strictEquals and the format actual, expected
targos
approved these changes
Jul 27, 2019
hiroppy
approved these changes
Jul 27, 2019
ZYSzys
approved these changes
Jul 28, 2019
Collaborator
ZYSzys
added
the
author ready
Trott
approved these changes
Jul 28, 2019
cjihrig
approved these changes
Jul 29, 2019
jasnell
approved these changes
Jul 29, 2019
Member
|
Landed in 2713f78 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 29, 2019
refactor the test for isObject function including falsy values, the use of strictEquals and the format actual, expected PR-URL: nodejs#28878 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
refactor the test for isObject function including falsy values, the use of strictEquals and the format actual, expected PR-URL: #28878 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the test for
isObjectfunction including falsy values,the use of strictEquals and the format
actual,expectedmake -j4 test(UNIX)