module: unify package exports test for CJS and ESM#28831
Closed
hybrist wants to merge 1 commit intonodejs:masterfrom
Closed
module: unify package exports test for CJS and ESM#28831hybrist wants to merge 1 commit intonodejs:masterfrom
hybrist wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
hybrist
added
esm
hybrist
commented
Jul 24, 2019
hybrist
commented
Jul 24, 2019
hybrist
force-pushed
the
one-exports-test
branch
from
5db4226 to
5d8e3fb
Compare
hybrist
changed the title
hybrist
force-pushed
the
one-exports-test
branch
from
5d8e3fb to
84ccea8
Compare
guybedford
approved these changes
Jul 24, 2019
Contributor
guybedford
left a comment
guybedford
left a comment
There was a problem hiding this comment.
Great to have unified tests indeed.
hybrist
force-pushed
the
one-exports-test
branch
from
84ccea8 to
aab065b
Compare
Contributor
Author
|
/cc @nodejs/modules-active-members |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
hybrist
added
the
author ready
Member
|
This could use more reviews. @nodejs/collaborators |
Contributor
|
More approvals would be great, but this should still be good to merge given the 7 days now I believe. |
gengjiawen
reviewed
Jul 31, 2019
Trott
approved these changes
Jul 31, 2019
Trott
requested changes
Jul 31, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
abort/test-addon-uv-handle-leak is failing locally for me with this change. Will re-run CI while I investigate locally.... Could be something incompatible slipped in while this PR was baking....
Collaborator
Trott
approved these changes
Jul 31, 2019
Member
|
Looks like I just needed to do a more thorough rebuild to catch up my addons. I think this is good although out of caution, I'll wait for the CI re-run results. |
Collaborator
Member
|
Landed in 61f3a5c |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 31, 2019
Refs: nodejs/modules#358 PR-URL: nodejs#28831 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 2, 2019
Refs: nodejs/modules#358 PR-URL: #28831 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/modules#358
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes