doc: fix link from bootstrap README to BUILDING#28504
Closed
rvagg wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fix link from bootstrap README to BUILDING#28504rvagg wants to merge 1 commit intonodejs:masterfrom
rvagg wants to merge 1 commit intonodejs:masterfrom
Conversation
rvagg
added
doc
richardlau
approved these changes
Jul 2, 2019
rvagg
force-pushed
the
rvagg/bootstrap-link
branch
from
4323cba to
e6f64b9
Compare
Trott
approved these changes
Jul 2, 2019
trivikr
approved these changes
Jul 2, 2019
Member
|
Like this comment to fast track this changes |
Member
trivikr
added
the
author ready
ZYSzys
approved these changes
Jul 2, 2019
lpinca
approved these changes
Jul 2, 2019
Member
|
Landed in 3ab457e |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 2, 2019
PR-URL: nodejs#28504 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
PR-URL: #28504 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I messed up #28465 and only noticed after it landed. tools/bootstrap/README.md points to README.md when it should point to BUILDING.md.
Here's the rendered version if you want to confirm I have it right this time.