Closed
Conversation
Bind to port 0 instead of 3000 Test does not require a well known port so it doesn't need port 3000 or common.PORT. Tests were failing on my CI box because port 3000 was already taken.
nodejs-github-bot
added
async_hooks
Member
|
Hi, thanks for your contribution. I believe this is already being changed in #28312. |
Contributor
Author
|
Damn, not sure how I missed that. Feel free to close this
…On Thu, Jun 27, 2019, 8:07 PM Richard Lau ***@***.***> wrote:
Hi, thanks for your contribution. I believe this is already being changed
in #28312 <#28312>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28462?email_source=notifications&email_token=AAE6WM3GPQG4PTT5DFO72RDP4V56ZA5CNFSM4H4BSNUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYY5MOA#issuecomment-506582584>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAE6WM5Q7R4VJH7GDELIMUTP4V56ZANCNFSM4H4BSNUA>
.
|
Member
We have 300 open pull requests. It's easy to miss something. 😀 |
Member
|
Fixed in bf7edaa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind to port 0 instead of 3000
Test does not require a well known port so it doesn't need port 3000 or
common.PORT. Tests were failing on my CI box because port 3000 was
already taken.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes