http2: propagate session destroy code to streams#28435
Merged
cjihrig merged 1 commit intonodejs:masterfrom Jun 28, 2019
Merged
Conversation
Trott
approved these changes
Jun 26, 2019
Contributor
Author
|
cc: @nodejs/http2 |
mcollina
approved these changes
Jun 27, 2019
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
LGTM
What do you think is the correct semver level for this? semver-minor or patch?
Contributor
Author
|
The current behavior definitely seems like a bug to me, but it's also a behavior change. I'd be OK with patch or major. |
Member
|
Hey, sorry I didn't get back on the twitter dm on this @cjihrig... propagating the code is fine, I think, at least for http2 (later, for http3, those semantics will be much more clearly defined). |
jasnell
approved these changes
Jun 27, 2019
Collaborator
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/24118/ EDIT(cjihrig): CI was green. |
trivikr
approved these changes
Jun 27, 2019
Contributor
Author
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1891/ |
Contributor
Author
|
CITGM finished running, if anyone is comfortable interpreting the results. |
Currently, when an HTTP2 session is destroyed with a code, that code is not propagated to the destroy() call of the session's streams. This commit forwards any code used to destroy a session to its corresponding streams. PR-URL: nodejs#28435 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Currently, when an HTTP2 session is destroyed with a code, that code is not propagated to the destroy() call of the session's streams. This commit forwards any code used to destroy a session to its corresponding streams. PR-URL: #28435 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Currently, when an HTTP2 session is destroyed with a code, that code is not propagated to the destroy() call of the session's streams. This commit forwards any code used to destroy a session to its corresponding streams. PR-URL: #28435 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when an HTTP2 session is destroyed with a code, that code is not propagated to the
destroy()call of the session's streams. This commit forwards any code used to destroy a session to its corresponding streams.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes