doc: add missing word in frameError event docs#28387
Merged
cjihrig merged 1 commit intonodejs:masterfrom Jun 24, 2019
Merged
Conversation
nodejs-github-bot
added
doc
lpinca
approved these changes
Jun 22, 2019
trivikr
approved these changes
Jun 23, 2019
antsmartian
approved these changes
Jun 23, 2019
jasnell
approved these changes
Jun 23, 2019
Trott
approved these changes
Jun 24, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Aside: What's with the odd "an attempt to emit" phrasing here? Is the idea that the event might not actually be emitted?
Contributor
Author
It looks like the event should be emitted, but I didn't write the original docs, so I'm not 100% sure what the intention was. I guess there is always the possibility that the stream has been destroyed. |
Contributor
Author
PR-URL: nodejs#28387 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28387 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes