buffer: consider deprecated raws as valid encoding#2829
buffer: consider deprecated raws as valid encoding#2829thefourtheye wants to merge 1 commit intonodejs:masterfrom
Conversation
Even though `raws` is a deprecated encoding, it is still valid as per `ParseEncoding` in `node.cc`.
|
Or it could be removed, it's been deprecated forever: 07792af. |
|
Are there any npm modules that use the |
|
A quick grep over 1/3 of npm packages showed no signs of Note that my package set includes only the last version of packages, and may be biased (it's actually packages that were published with npm2+). I have a new and complete set (still only the last versions, though), but I did not prepare a searchable form of those yet. |
|
@ChALkeR Can you please grep |
|
@thefourtheye I will prepare a searchable file of the current versions of all packages in the coming days and will publish it, so that everyone could perform those tests. The expected file size is around 3 GiB compressed with |
|
Thanks @ChALkeR :-) Let's hear what @trevnorris thinks. |
|
Whatever change is made, make sure it's reflected in the native code. I say just remove it (and raw). Been deprecated as long as I can remember, and never seen it used. |
As `raw` and `raws` encodings are deprecated for such a long time, and it is an undocumented feature. This patch removes the support for those encoding completely. Previous discussion: nodejs#2829
|
Closing in favor of #2859 |
As `raw` and `raws` encodings are deprecated for such a long time, and they both are undocumented, this patch removes the support for those encodings completely. Previous discussion: #2829 PR-URL: #2859 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Even though
rawsis a deprecated encoding, it is still valid as perParseEncodinginnode.cc.Refer https://github.com/nodejs/node/blob/v4.0.0/src/node.cc#L1214-L1218
cc @trevnorris