test: add Worker + uncaughtException + process.exit() test#28259
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
test: add Worker + uncaughtException + process.exit() test#28259addaleax wants to merge 2 commits intonodejs:masterfrom
addaleax wants to merge 2 commits intonodejs:masterfrom
Conversation
addaleax
added
test
Collaborator
|
Sadly, an error occurred when I tried to trigger a build. :( |
2 tasks
gireeshpunathil
approved these changes
Jun 17, 2019
Trott
requested changes
Jun 17, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
This test will fail if run with the tools/test.py --worker.
Member
|
Maybe put the worker code in a fixture instead? So it won't get run by |
Member
Author
|
@joyeecheung @Trott I’ve updated this with the standard approach we use in our tests (using an env var instead of |
Collaborator
joyeecheung
approved these changes
Jun 17, 2019
Trott
approved these changes
Jun 17, 2019
fhinkel
approved these changes
Jun 19, 2019
Member
Author
|
Landed in 7146ddd |
pull bot
pushed a commit
to Rachelmorrell/node
that referenced
this pull request
Jun 19, 2019
PR-URL: nodejs#28259 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
PR-URL: #28259 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes