tls: rename validateKeyCert in _tls_common.js#28116
Closed
danbev wants to merge 2 commits intonodejs:masterfrom
Closed
tls: rename validateKeyCert in _tls_common.js#28116danbev wants to merge 2 commits intonodejs:masterfrom
danbev wants to merge 2 commits intonodejs:masterfrom
Conversation
Collaborator
|
Sadly, an error occurred when I tried to trigger a build. :( |
Collaborator
Contributor
|
s/_tls_commons/_tls_common/ in commit message |
Contributor
|
Also I think the subsystem prefix should be |
This commit renames validateKeyCert to validateKeyCertArg to avoid confusing this with something that would validate the actual key or certificate.
danbev
force-pushed
the
validateKeyCertArg
branch
from
2b85de2 to
d048ddb
Compare
Contributor
Author
|
@mscdex Thanks, I've fixed both issues now. |
danbev
changed the title
antsmartian
approved these changes
Jun 7, 2019
cjihrig
approved these changes
Jun 7, 2019
Contributor
|
I'm fine with this, as-is, but maybe |
lpinca
approved these changes
Jun 7, 2019
Contributor
Author
I like that better. I've updated with a commit now. Thanks |
This comment has been minimized.
This comment has been minimized.
sam-github
approved these changes
Jun 10, 2019
jasnell
approved these changes
Jun 10, 2019
danbev
added
the
author ready
Trott
approved these changes
Jun 13, 2019
Member
Member
|
Landed in 173bee2 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 13, 2019
This commit renames validateKeyCert to validateKeyCertArg to avoid confusing this with something that would validate the actual key or certificate. PR-URL: nodejs#28116 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Jun 17, 2019
This commit renames validateKeyCert to validateKeyCertArg to avoid confusing this with something that would validate the actual key or certificate. PR-URL: #28116 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit renames validateKeyCert to validateKeyCertArg to avoid
confusing this with something that would validate the actual key or
certificate.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes