doc: document trace-events category for dns requests#28100
Closed
vmarchaud wants to merge 1 commit intonodejs:masterfrom
Closed
doc: document trace-events category for dns requests#28100vmarchaud wants to merge 1 commit intonodejs:masterfrom
vmarchaud wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Jun 6, 2019
Trott
reviewed
Jun 6, 2019
Trott
approved these changes
Jun 6, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with or without my minor suggestion
As implemented in nodejs#21840, dns can emit trace events when the category is enabled. This PR just add it to the documentation.
vmarchaud
force-pushed
the
trace_events_dns
branch
from
d1a5e26 to
bfeb47e
Compare
jasnell
approved these changes
Jun 10, 2019
Member
Trott
added
the
author ready
Member
|
Landed in f7ffa52 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jun 13, 2019
As implemented in nodejs#21840, dns can emit trace events when the category is enabled. This PR just add it to the documentation. PR-URL: nodejs#28100 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As implemented in #21840, dns can
emit trace events when the category is enabled. This PR just add
it to the documentation.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes