doc: add unrepresented flags docs for configure#28069
Closed
rexagod wants to merge 3 commits intonodejs:masterfrom
Closed
doc: add unrepresented flags docs for configure#28069rexagod wants to merge 3 commits intonodejs:masterfrom
configure#28069rexagod wants to merge 3 commits intonodejs:masterfrom
Conversation
configure
refack
reviewed
Jun 5, 2019
Member
Author
|
@refack Hey! Apologies for the delay, also, I was having a bit of trouble understanding what exactly to add in the Thank you! |
Member
Author
|
Changing the first commit body! |
developed on ffb1819 by wrapping content for lint tests to pass Refs: nodejs#28069
added documentation to support usage of advanced features of `configure` on Windows Fixes: nodejs#17331
developed on fcc6b1 by wrapping content for lint tests to pass Refs: nodejs#28069
Member
Author
|
Pinging @refack for a look here. Thanks! |
bnoordhuis
approved these changes
Jul 5, 2019
Member
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM although doc/guides/maintaining-the-build-files.md isn't perhaps the most visible place for it.
jasnell
approved these changes
Jul 15, 2019
gireeshpunathil
approved these changes
Dec 22, 2019
Collaborator
Member
|
Landed in 2c5d35e 🎉 The linter complaint due to recent changes. I fixed these issues while landing. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configureon WindowsFixes: #17331
Checklist
/cc @refack