completed secure-pair performance test with clear connections#27971
Closed
tufosa wants to merge 2 commits intonodejs:masterfrom
Closed
completed secure-pair performance test with clear connections#27971tufosa wants to merge 2 commits intonodejs:masterfrom
tufosa wants to merge 2 commits intonodejs:masterfrom
Conversation
adds clear connections to the secure-pair performance test to prove thah in some cases (when the sender send the data in small chunks) clear connections perform worse than TLS connections Refs: nodejs#27970
nodejs-github-bot
added
benchmark
Member
|
@tufosa Does it make sense to add a smaller chunk size to |
Author
Author
|
@addaleax it's my first PR to this project and I am not sure how can we move this forward. Everything seems OK, but I don't know if I need to do anything else in order to get this reviewed and eventually approved. Can you help me with this? |
Member
|
ping @addaleax |
Collaborator
addaleax
approved these changes
Dec 18, 2019
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
@gireeshpunathil Anything in particular I’d need to be aware of here?
Member
|
@addaleax - no, I pinged because I see this PR not moving and saw you as the only person engaged on this PR so far; so! |
jasnell
approved these changes
Dec 18, 2019
Collaborator
Collaborator
gireeshpunathil
pushed a commit
that referenced
this pull request
Dec 20, 2019
adds clear connections to the secure-pair performance test to prove that in some cases (when the sender send the data in small chunks) clear connections perform worse than TLS connections Also add a byte chunk size test to benchmark/net/net-pipe.js Refs: #27970 PR-URL: #27971 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
landed in fc553fd thanks for the contribution! |
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
adds clear connections to the secure-pair performance test to prove that in some cases (when the sender send the data in small chunks) clear connections perform worse than TLS connections Also add a byte chunk size test to benchmark/net/net-pipe.js Refs: #27970 PR-URL: #27971 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
adds clear connections to the secure-pair performance test to prove that in some cases (when the sender send the data in small chunks) clear connections perform worse than TLS connections Also add a byte chunk size test to benchmark/net/net-pipe.js Refs: #27970 PR-URL: #27971 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
adds clear connections to the secure-pair performance test to prove that in some cases (when the sender send the data in small chunks) clear connections perform worse than TLS connections Also add a byte chunk size test to benchmark/net/net-pipe.js Refs: #27970 PR-URL: #27971 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very simple patch to the existing secure-pair benchmark in order to include clear connections in the test and expose this issue
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes