deps: upgrade to libuv 1.29.1 by cjihrig · Pull Request #27718 · nodejs/node

cjihrig · 2019-05-15T17:27:47Z

Notable changes:

uv_get_constrained_memory() has been added.
A race condition in uv_async_send() has been fixed.
uv_get_free_memory() and uv_get_total_memory() now read from
/proc/meminfo, which should improve correctness when called
from inside an lxc container.
A failed assertion in uv_fs_poll_stop() has been fixed.
A bug in MAC addresses for IP-aliases has been fixed.

Fixes: #27170
Fixes: #27493

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2019-05-15T17:27:49Z

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3529

nodejs-github-bot · 2019-05-15T18:16:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23129/

nodejs-github-bot · 2019-05-15T19:40:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23130/

bnoordhuis

LGTM. Also closes out #27493.

nodejs-github-bot · 2019-05-16T15:33:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23144/

EDIT(cjihrig): CI was green.

cjihrig · 2019-05-17T19:29:52Z

@bnoordhuis should we hold off on landing this until libuv/libuv#2297 is resolved?

Trott

Rubber-stamp LGTM

bnoordhuis · 2019-05-20T11:54:45Z

should we hold off on landing this until libuv/libuv#2297 is resolved?

I think that would be a good idea. I don't fully understand yet what's causing it.

nodejs-github-bot · 2019-05-21T14:01:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/23256/

EDIT(cjihrig): CI was yellow.

cjihrig · 2019-05-21T14:01:37Z

This is now 1.29.1.

refack

reify

Notable changes: - uv_get_constrained_memory() has been added. - A race condition in uv_async_send() has been fixed. - uv_get_free_memory() and uv_get_total_memory() now read from /proc/meminfo, which should improve correctness when called from inside an lxc container. - A failed assertion in uv_fs_poll_stop() has been fixed. - A bug in MAC addresses for IP-aliases has been fixed. Fixes: nodejs#27170 Fixes: nodejs#27493 PR-URL: nodejs#27718 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: - uv_get_constrained_memory() has been added. - A race condition in uv_async_send() has been fixed. - uv_get_free_memory() and uv_get_total_memory() now read from /proc/meminfo, which should improve correctness when called from inside an lxc container. - A failed assertion in uv_fs_poll_stop() has been fixed. - A bug in MAC addresses for IP-aliases has been fixed. Fixes: #27170 Fixes: #27493 PR-URL: #27718 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes * deps: * Fix handling of +0/-0 when constant field tracking is enabled (Michaël Zasso) #27792 * Fix `os.freemem()` and `os.totalmem` correctness (cjihrig) #27718 * src: * Fix v12.3.0 regression that prevents native addons from compiling #27804 PR-URL: #27814

Notable changes * deps: * Fix handling of +0/-0 when constant field tracking is enabled (Michaël Zasso) nodejs#27792 * Fix `os.freemem()` and `os.totalmem` correctness (cjihrig) nodejs#27718 * src: * Fix v12.3.0 regression that prevents native addons from compiling nodejs#27804 PR-URL: nodejs#27814

Notable changes: - uv_get_constrained_memory() has been added. - A race condition in uv_async_send() has been fixed. - uv_get_free_memory() and uv_get_total_memory() now read from /proc/meminfo, which should improve correctness when called from inside an lxc container. - A failed assertion in uv_fs_poll_stop() has been fixed. - A bug in MAC addresses for IP-aliases has been fixed. Fixes: nodejs#27170 Fixes: nodejs#27493 PR-URL: nodejs#27718 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: - uv_get_constrained_memory() has been added. - A race condition in uv_async_send() has been fixed. - uv_get_free_memory() and uv_get_total_memory() now read from /proc/meminfo, which should improve correctness when called from inside an lxc container. - A failed assertion in uv_fs_poll_stop() has been fixed. - A bug in MAC addresses for IP-aliases has been fixed. Fixes: #27170 Fixes: #27493 PR-URL: #27718 Backport-PR-URL: #31969 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label May 15, 2019

cjihrig force-pushed the libuv branch from 0a1012d to 393fc55 Compare May 15, 2019 17:41

refack approved these changes May 15, 2019

View reviewed changes

ofrobots approved these changes May 15, 2019

View reviewed changes

bnoordhuis approved these changes May 16, 2019

View reviewed changes

gengjiawen approved these changes May 16, 2019

View reviewed changes

santigimeno approved these changes May 16, 2019

View reviewed changes

Trott approved these changes May 17, 2019

View reviewed changes

jasnell approved these changes May 18, 2019

View reviewed changes

Trott added the blocked PRs that are blocked by other issues or PRs. label May 20, 2019

cjihrig changed the title ~~deps: upgrade to libuv 1.29.0~~ deps: upgrade to libuv 1.29.1 May 21, 2019

cjihrig removed the blocked PRs that are blocked by other issues or PRs. label May 21, 2019

cjihrig force-pushed the libuv branch from 393fc55 to f865541 Compare May 21, 2019 14:00

refack approved these changes May 21, 2019

View reviewed changes

cjihrig force-pushed the libuv branch from f865541 to 46d8af5 Compare May 21, 2019 14:38

cjihrig merged commit 46d8af5 into nodejs:master May 21, 2019

cjihrig deleted the libuv branch May 21, 2019 14:39

BridgeAR mentioned this pull request May 22, 2019

v12.3.1 proposal #27814

Merged

BethGriggs mentioned this pull request Mar 12, 2020

v10.20.0 proposal #31984

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

deps: upgrade to libuv 1.29.1#27718

deps: upgrade to libuv 1.29.1#27718
cjihrig merged 1 commit intonodejs:masterfrom
cjihrig:libuv

cjihrig commented May 15, 2019 •

edited

Loading

Uh oh!

nodejs-github-bot commented May 15, 2019

Uh oh!

nodejs-github-bot commented May 15, 2019

Uh oh!

nodejs-github-bot commented May 15, 2019

Uh oh!

bnoordhuis left a comment

Uh oh!

nodejs-github-bot commented May 16, 2019 •

edited by cjihrig

Loading

Uh oh!

cjihrig commented May 17, 2019

Uh oh!

Trott left a comment

Uh oh!

bnoordhuis commented May 20, 2019

Uh oh!

nodejs-github-bot commented May 21, 2019 •

edited by cjihrig

Loading

Uh oh!

cjihrig commented May 21, 2019

Uh oh!

refack left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

cjihrig commented May 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented May 15, 2019

Uh oh!

nodejs-github-bot commented May 15, 2019

Uh oh!

nodejs-github-bot commented May 15, 2019

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 16, 2019 • edited by cjihrig Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjihrig commented May 17, 2019

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented May 20, 2019

Uh oh!

nodejs-github-bot commented May 21, 2019 • edited by cjihrig Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cjihrig commented May 21, 2019

Uh oh!

refack left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

cjihrig commented May 15, 2019 •

edited

Loading

nodejs-github-bot commented May 16, 2019 •

edited by cjihrig

Loading

nodejs-github-bot commented May 21, 2019 •

edited by cjihrig

Loading