Skip to content

http: reduce usage of public util#26548

Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:util-http
Closed

http: reduce usage of public util#26548
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:util-http

Conversation

@ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Mar 9, 2019 •
edited
Loading

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Mar 9, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 9, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21375/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2019
@danbev
Copy link
Contributor

danbev commented Mar 12, 2019

Landed in 4c4e4f4.

@danbev danbev closed this Mar 12, 2019
pull bot pushed a commit to Rachelmorrell/node that referenced this pull request Mar 12, 2019
@ZYSzys @danbev
http: reduce usage of public util
4c4e4f4 
PR-URL: nodejs#26548
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ZYSzys ZYSzys deleted the util-http branch March 12, 2019 05:52
@BridgeAR
Copy link
Member

BridgeAR commented Mar 13, 2019

This does not land cleanly on v11. It seems to rely on other commits that should be backported first. Please open a manual backport for it or change the labels accordingly.

@refack refack mentioned this pull request Mar 14, 2019
Closed
2 tasks
@refack
Copy link
Contributor

refack commented Mar 14, 2019

Backport PR: #26650

refack pushed a commit to refack/node that referenced this pull request Mar 14, 2019
@ZYSzys @refack
http: reduce usage of public util
cd77811 
PR-URL: nodejs#26548
Refs: nodejs#26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@refack refack self-assigned this Mar 14, 2019
@refack refack mentioned this pull request Mar 14, 2019
Closed
@joyeecheung joyeecheung mentioned this pull request Mar 20, 2019
Closed
targos pushed a commit that referenced this pull request Mar 28, 2019
@ZYSzys @targos
http: reduce usage of public util
04441b5 
Backport-PR-URL: #26650
PR-URL: #26548
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Mar 30, 2019
@ZYSzys @targos
http: reduce usage of public util
5a29a94 
Backport-PR-URL: #26650
PR-URL: #26548
Refs: #26546
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
@refack refack removed their assignment Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ZYSzys @BridgeAR @danbev @refack @jasnell @cjihrig @targos @nodejs-github-bot