worker: release native Worker object earlier#26542
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
worker: release native Worker object earlier#26542addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
Destroy the `Worker` class earlier, because we don’t need access to it once the thread has stopped and all resources have been cleaned up. Fixes: nodejs#26535
nodejs-github-bot
added
the
c++
gireeshpunathil
approved these changes
Mar 9, 2019
joyeecheung
approved these changes
Mar 9, 2019
devsnek
approved these changes
Mar 9, 2019
Member
|
CI https://ci.nodejs.org/job/node-test-pull-request/21373/ (:heavy_check_mark:) |
BridgeAR
added
the
author ready
jasnell
approved these changes
Mar 10, 2019
cjihrig
approved these changes
Mar 10, 2019
Contributor
|
Landed in c51735f. |
danbev
pushed a commit
that referenced
this pull request
Mar 12, 2019
Destroy the `Worker` class earlier, because we don’t need access to it once the thread has stopped and all resources have been cleaned up. PR-URL: #26542 Fixes: #26535 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 13, 2019
Destroy the `Worker` class earlier, because we don’t need access to it once the thread has stopped and all resources have been cleaned up. PR-URL: #26542 Fixes: #26535 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Destroy the `Worker` class earlier, because we don’t need access to it once the thread has stopped and all resources have been cleaned up. PR-URL: #26542 Fixes: #26535 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destroy the
Workerclass earlier, because we don’t need accessto it once the thread has stopped and all resources have been
cleaned up.
Fixes: #26535
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes