Skip to content

url: require encodeStr from internal/querystring#26538

Closed
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:url-encodeStr
Closed

url: require encodeStr from internal/querystring#26538
ZYSzys wants to merge 1 commit intonodejs:masterfrom
zys-contrib:url-encodeStr

Conversation

@ZYSzys
Copy link
Member

@ZYSzys ZYSzys commented Mar 9, 2019

encodeStr function is exported from internal/querystring.js originally.

node/lib/internal/querystring.js

Lines 92 to 96 in 1acf3b1

module.exports = {
encodeStr,
hexTable,
isHexTable
};

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Mar 9, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 9, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21376/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2019
@danbev
Copy link
Contributor

danbev commented Mar 12, 2019

Landed in 7ac904e.

@danbev danbev closed this Mar 12, 2019
danbev pushed a commit that referenced this pull request Mar 12, 2019
@ZYSzys @danbev
url: require encodeStr from internal/querystring
7ac904e 
PR-URL: #26538
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ZYSzys ZYSzys deleted the url-encodeStr branch March 12, 2019 06:00
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@ZYSzys @BridgeAR
url: require encodeStr from internal/querystring
f2ebf36 
PR-URL: #26538
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@ZYSzys @BridgeAR
url: require encodeStr from internal/querystring
1de9e13 
PR-URL: #26538
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. url Issues and PRs related to the legacy built-in url module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ZYSzys @BridgeAR @danbev @jasnell @lpinca @targos @nodejs-github-bot