process: make Symbol.toStringTag writable#26488
Closed
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Closed
process: make Symbol.toStringTag writable#26488BridgeAR wants to merge 1 commit intonodejs:masterfrom
BridgeAR wants to merge 1 commit intonodejs:masterfrom
Conversation
The ecosystem broke by making it non-writable, so this is a good intermediate fix.
Member
Author
|
We could switch this to use |
3 tasks
Contributor
|
Actually making it a getter so we can deprecate it as major does sound sensible. Especially given Jest already have a fix here. Shall we do a docs-only deprecation here then? |
targos
approved these changes
Mar 7, 2019
hiroppy
approved these changes
Mar 8, 2019
6 tasks
jasnell
approved these changes
Mar 8, 2019
Member
Author
BridgeAR
added
the
author ready
himself65
approved these changes
Mar 9, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: nodejs#26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in 2a7da11 🎉 |
BridgeAR
added a commit
that referenced
this pull request
Mar 13, 2019
The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: #26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
added a commit
that referenced
this pull request
Mar 13, 2019
Notable Changes
* build:
* Enable v8's siphash for hash seed creation (Rod Vagg)
#26367
* crypto:
* Add `KeyObject.asymmetricKeySize` (Patrick Gansterer)
#26387
* deps:
* Upgrade openssl to 1.1.1b (Sam Roberts)
#26327
* process:
* Make `process[Symbol.toStringTag]` writable again
(Ruben Bridgewater) #26488
* repl:
* Add `util.inspect.replDefaults` to customize the writer
(Ruben Bridgewater) #26375
* report:
* Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
#26527
Member
Author
|
@guybedford are you going to open a PR for the deprecation? I personally have no strong opinion about that. |
BridgeAR
added a commit
that referenced
this pull request
Mar 14, 2019
The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: #26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
added a commit
that referenced
this pull request
Mar 14, 2019
Notable Changes
* bootstrap:
* Add experimental `--frozen-intrinsics` flag (Guy Bedford)
#25685
* build:
* Enable v8's siphash for hash seed creation (Rod Vagg)
#26367
* deps:
* Upgrade openssl to 1.1.1b (Sam Roberts)
#26327
* process:
* Make `process[Symbol.toStringTag]` writable again
(Ruben Bridgewater) #26488
* repl:
* Add `util.inspect.replDefaults` to customize the writer
(Ruben Bridgewater) #26375
* report:
* Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
#26527
Contributor
|
@BridgeAR I know it seems small, but intrinsics have non-writeable toStringTags because they are supposed to provide a certain level of consistency so I do think it would be more correct to do this. I don't feel particularly strongly about it either, but will aim to get to the PR as it seems better than not. |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 14, 2019
The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: nodejs#26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 14, 2019
Notable Changes
* bootstrap:
* Add experimental `--frozen-intrinsics` flag (Guy Bedford)
nodejs#25685
* build:
* Enable v8's siphash for hash seed creation (Rod Vagg)
nodejs#26367
* deps:
* Upgrade openssl to 1.1.1b (Sam Roberts)
nodejs#26327
* process:
* Make `process[Symbol.toStringTag]` writable again
(Ruben Bridgewater) nodejs#26488
* repl:
* Add `util.inspect.replDefaults` to customize the writer
(Ruben Bridgewater) nodejs#26375
* report:
* Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
nodejs#26527
BridgeAR
added a commit
that referenced
this pull request
Mar 14, 2019
The ecosystem broke by making it non-writable, so this is a good intermediate fix. PR-URL: #26488 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@hiroppy.me> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
added a commit
that referenced
this pull request
Mar 14, 2019
Notable Changes
* bootstrap:
* Add experimental `--frozen-intrinsics` flag (Guy Bedford)
#25685
* build:
* Enable v8's siphash for hash seed creation (Rod Vagg)
#26367
* deps:
* Upgrade openssl to 1.1.1b (Sam Roberts)
#26327
* process:
* Make `process[Symbol.toStringTag]` writable again
(Ruben Bridgewater) #26488
* repl:
* Add `util.inspect.replDefaults` to customize the writer
(Ruben Bridgewater) #26375
* report:
* Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
#26527
BridgeAR
added a commit
that referenced
this pull request
Mar 15, 2019
Notable Changes
* bootstrap:
* Add experimental `--frozen-intrinsics` flag (Guy Bedford)
#25685
* build:
* Enable v8's siphash for hash seed creation (Rod Vagg)
#26367
* deps:
* Upgrade openssl to 1.1.1b (Sam Roberts)
#26327
* process:
* Make `process[Symbol.toStringTag]` writable again
(Ruben Bridgewater) #26488
* repl:
* Add `util.inspect.replDefaults` to customize the writer
(Ruben Bridgewater) #26375
* report:
* Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
#26527
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 15, 2019
Notable Changes
* bootstrap:
* Add experimental `--frozen-intrinsics` flag (Guy Bedford)
nodejs#25685
* build:
* Enable v8's siphash for hash seed creation (Rod Vagg)
nodejs#26367
* deps:
* Upgrade openssl to 1.1.1b (Sam Roberts)
nodejs#26327
* process:
* Make `process[Symbol.toStringTag]` writable again
(Ruben Bridgewater) nodejs#26488
* repl:
* Add `util.inspect.replDefaults` to customize the writer
(Ruben Bridgewater) nodejs#26375
* report:
* Rename `triggerReport()` to `writeReport()` (Colin Ihrig)
nodejs#26527
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ecosystem broke by making it non-writable, so this is a good
intermediate fix.
Refs: #25963 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes