Revert "build: silence cpp lint by default"

[refack]

This reverts commit 0373836.

PR effect is semver major, and removes an escape hatch.
This landed without proper review from @nodejs/build-files

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2713/pipeline

[refack]

IIUC the original intent was to change

node/Makefile

Lines 57 to 60 in 0373836

	# Default to verbose builds.
	# To do quiet/pretty builds, run `make V=` to set V to an empty string,
	# or set the V environment variable to an empty string.
	V ?= 1

[BridgeAR]

@refack the regular cpp linting output is super verbose. This does not seem to be a good default. And in what way is the behavior semver-major? Do we count the output of our makefile towards semver-major?

I guess ideally, we'd have an opt-in to get the verbose cpp linting output.

[danbev]

I would prefer to make lint-cpp quiet by default as it does not really provide any information except that what files it is processing. I understand that this is possible using the verbose flag but at least I personally don't use it very often.

I don't want to block this as there are already approvals so I'm going to remove myself from the reviews list.

[joyeecheung]

Why is the effect semver-major?

[refack]

CI: https://ci.nodejs.org/job/node-test-pull-request/21315/

Why is the effect semver-major?

And in what way is the behavior semver-major?

1. Output of the build process is semver-major for downstream embedders (and you CI scripts).
2. In principal the Makefile should be able to output full logs for tracing & debugging. The reverted commit disabled any way of getting that output.
3. I'd be +1 on changing

   node/Makefile

   Lines 57 to 60 in 0373836

   	# Default to verbose builds.
   	# To do quiet/pretty builds, run `make V=` to set V to an empty string,
   	# or set the V environment variable to an empty string.
   	V ?= 1

   
   In the meantime make V=0 should work just fine.

[refack]

P.S. the lint-cpp target is timestamp aware. So only files changed should show up in the default output.