Closed
Conversation
Update babel-eslint to 10.0.1.
Collaborator
|
@Trott sadly an error occured when I tried to trigger a build :( |
Member
Author
cjihrig
approved these changes
Feb 28, 2019
Trott
added
the
author ready
Leko
approved these changes
Feb 28, 2019
Member
|
Landed in 536e062 |
addaleax
pushed a commit
that referenced
this pull request
Mar 2, 2019
Update babel-eslint to 10.0.1. PR-URL: #26347 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax
pushed a commit
that referenced
this pull request
Mar 2, 2019
Update babel-eslint to 10.0.1. PR-URL: #26347 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update babel-eslint to 10.0.1.
The version we ship with currently has some minor vulnerabilities in
lodashin its dependency tree. This won't affect end users, of course, but it does generate noise in some auditing tools, and we should set a good example in the source code and not use versions of tools with known vulnerabilities.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes