Skip to content

src: remove unused macro in env.cc#26273

Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen:cleanup_env.cc
Closed

src: remove unused macro in env.cc#26273
gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen:cleanup_env.cc

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Feb 23, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 23, 2019
@gengjiawen
Copy link
Member Author

gengjiawen commented Mar 2, 2019

@addaleax Can you trigger Jenkins ci for this pr ? Thanks.

@addaleax
Copy link
Member

addaleax commented Mar 2, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21132/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 2, 2019
@antsmartian
Copy link
Contributor

antsmartian commented Mar 3, 2019

Landed in d16cfa4 🎉 🎉 Thanks @gengjiawen 👍

@antsmartian antsmartian closed this Mar 3, 2019
antsmartian pushed a commit that referenced this pull request Mar 3, 2019
@gengjiawen @antsmartian
src: remove unused macro in env.cc
d16cfa4 
PR-URL: #26273
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR pushed a commit that referenced this pull request Mar 4, 2019
@gengjiawen @BridgeAR
src: remove unused macro in env.cc
2438a43 
PR-URL: #26273
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@gengjiawen @addaleax @antsmartian @jasnell @lpinca @cjihrig @tniessen @richardlau @BridgeAR @nodejs-github-bot