src: simplify loop arithmetic in GetCPUInfo#26183
Closed
gireeshpunathil wants to merge 5 commits intonodejs:masterfrom
Closed
src: simplify loop arithmetic in GetCPUInfo#26183gireeshpunathil wants to merge 5 commits intonodejs:masterfrom
GetCPUInfo#26183gireeshpunathil wants to merge 5 commits intonodejs:masterfrom
Conversation
Cache the repeated operations and reuse; potentially generating efficient code in some platforms, and improving readability.
mscdex
reviewed
Feb 18, 2019
richardlau
reviewed
Feb 19, 2019
richardlau
approved these changes
Feb 19, 2019
BridgeAR
approved these changes
Feb 19, 2019
Member
Author
ZYSzys
reviewed
Feb 19, 2019
Member
Author
|
@ZYSzys - done, thanks! |
ZYSzys
reviewed
Feb 19, 2019
BridgeAR
reviewed
Feb 19, 2019
ZYSzys
approved these changes
Feb 19, 2019
apapirovski
approved these changes
Feb 20, 2019
jasnell
approved these changes
Feb 21, 2019
Contributor
|
Landed in e51da1f. |
danbev
pushed a commit
that referenced
this pull request
Feb 21, 2019
Cache the repeated operations and reuse; potentially generating efficient code in some platforms, and improving readability. PR-URL: #26183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 21, 2019
Cache the repeated operations and reuse; potentially generating efficient code in some platforms, and improving readability. PR-URL: #26183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Cache the repeated operations and reuse; potentially generating efficient code in some platforms, and improving readability. PR-URL: #26183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache the repeated operations and reuse; potentially generating
efficient code in some platforms, and improving readability.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes