build,test: guard eslint with crypto check

[danbev]

Currently, configuring --without-ssl will cause the lint-js target to
fail with the following error:

$ make lint-js
Running JS linter...
internal/util.js:101
    throw new ERR_NO_CRYPTO();
    ^

Error [ERR_NO_CRYPTO]:
Node.js is not compiled with OpenSSL crypto support
at assertCrypto (internal/util.js:101:11)
at crypto.js:31:1
...
(/node/tools/node_modules/eslint/node_modules/file-entry-cache/cache.js:2:14)
at Module._compile (internal/modules/cjs/loader.js:746:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:757:10)
make: *** [lint-js] Error 1

There are also a number of tests that are affected in a similar way.

This commit adds crypto checks to allow for lint-js and the affected
tests to be skipped when configured --without-ssl.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2655/pipeline

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/20868/

[richardlau]

Do you know if the test failures have always been like that without intl or is this a recent(ish) regression?

[danbev]

Do you know if the test failures have always been like that without intl or is this a recent(ish) regression?

I'm not sure about failures --without-intl but these ones are fairly recent, like in the last week I'd say. Perhaps after the ESLint upgrade (77b39c2).

[cjihrig]

It looks like tools/node_modules/eslint/node_modules/file-entry-cache/cache.js indeed just began require()ing crypto (https://github.com/nodejs/node/blame/fd0a861cdb3088f60ee56a8adef05fd50b71f817/tools/node_modules/eslint/node_modules/file-entry-cache/cache.js#L2).

That line seems to have landed upstream two years ago and just made it's way into eslint (https://github.com/royriojas/file-entry-cache/blame/03f700c99b76133dc14648b465a1550ec2930e5c/cache.js#L2).

[danbev]

Landed in f17f467.