src: add missing includes to build with vtune support#26136
Closed
uttampawar wants to merge 1 commit intonodejs:masterfrom
Closed
src: add missing includes to build with vtune support#26136uttampawar wants to merge 1 commit intonodejs:masterfrom
uttampawar wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Feb 15, 2019
uttampawar
changed the title
Member
|
CI: https://ci.nodejs.org/job/node-test-pull-request/20863/ (:heavy_check_mark:) |
jasnell
approved these changes
Feb 18, 2019
richardlau
approved these changes
Feb 18, 2019
addaleax
added
the
author ready
Contributor
|
Landed in 129516d. |
gabrielschulhof
pushed a commit
that referenced
this pull request
Feb 19, 2019
`v8-vtune.h` must be included in order to be able to build with vtune support. PR-URL: #26136 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Feb 21, 2019
`v8-vtune.h` must be included in order to be able to build with vtune support. PR-URL: #26136 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
`v8-vtune.h` must be included in order to be able to build with vtune support. PR-URL: #26136 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added missing includes (v8-vtune.h) in environment.cc to be able to build with vtune profiling support.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes